Skip to content

fix: add null checks to prevent crash when a chart is destroyed #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keithbrink wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Open

fix: add null checks to prevent crash when a chart is destroyed #12178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b2984f
fix: add null check to clipArea and unclipArea to prevent crash on de…
keithbrink Jan 15, 2026
94d8e3a
fix: add null check to getMaximumSize and getRelativePosition to prev…
keithbrink Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/helpers/helpers.canvas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,15 @@ export function _isPointInArea(
}

export function clipArea(ctx: CanvasRenderingContext2D, area: TRBL) {
if (!ctx) return;
ctx.save();
ctx.beginPath();
ctx.rect(area.left, area.top, area.right - area.left, area.bottom - area.top);
ctx.clip();
}

export function unclipArea(ctx: CanvasRenderingContext2D) {
if (!ctx) return;
ctx.restore();
}

Expand Down
10 changes: 10 additions & 0 deletions src/helpers/helpers.dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ export function getRelativePosition(
}

const {canvas, currentDevicePixelRatio} = chart;
// Guard against null canvas to prevent ownerDocument crash
if (!canvas) {
return {x: 0, y: 0};
}

const style = getComputedStyle(canvas);
const borderBox = style.boxSizing === 'border-box';
const paddings = getPositionedStyle(style, 'padding');
Expand Down Expand Up @@ -166,6 +171,11 @@ export function getMaximumSize(
bbHeight?: number,
aspectRatio?: number
): { width: number; height: number } {
// Guard against null canvas to prevent ownerDocument crash
if (!canvas) {
return {width: 0, height: 0};
}

const style = getComputedStyle(canvas);
const margins = getPositionedStyle(style, 'margin');
const maxWidth = parseMaxStyle(style.maxWidth, canvas, 'clientWidth') || INFINITY;
Expand Down