Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/602/assure window size msg comes first #605

Conversation

deicon
Copy link

@deicon deicon commented Nov 16, 2022

#602 Naive approach using a Program wide mutex to block all but the WindowSizeMsg until the WindowSizeMsg was received and processed in the Update method. Once this is done, the Program is marked with initDone and the mutex is no longer blocking the custom messages.

Not sure about this approach. Maybe a reviewer has a look at it

@meowgorithm
Copy link
Member

Hey @deicon! Thank you for the PR. For now I'm going to recommend we hold off on this per my comment in #602. We can reexamine this down the road if things change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants