Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): add support for dynamic frameworks #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sondremare
Copy link
Contributor

If one uses CocoaPods and installs the 'Analytics' pod using the option for dyamic frameworks (use_frameworks!) The import of SEGAnalytics will no longer work. With this support we support dynamic frameworks, while being backwards compatible.

If one uses CocoaPods and installs the 'Analytics' pod using the option for dyamic frameworks (use_frameworks!) The import of SEGAnalytics will no longer work. With this support we support dynamic frameworks, while being backwards compatible.
@pdavid0
Copy link

pdavid0 commented Jul 7, 2017

I tried your fix with and without use_frameworks! and it does not compile on RN 0.46.

fatal error: 'React/RCTBridgeModule.h' file not found

I tried #23 too.

Any idea ?

@roycclu
Copy link

roycclu commented May 29, 2018

Not using frameworks, but still seeing

fatal error: 'React/RCTBridgeModule.h' file not found
#import <React/RCTBridgeModule.h>

Any thoughts or ideas?

@roycclu
Copy link

roycclu commented May 29, 2018

Found solution. Add this line to the SegmentAnalytics.podspec file

  s.dependency 'React'

Should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants