TAXENGG-2901 (fix): Tax SPI Spec changes on address validation#52
TAXENGG-2901 (fix): Tax SPI Spec changes on address validation#52cb-adityabhat wants to merge 1 commit intomainfrom
Conversation
| errors: | ||
| - code: INVALID_DATA | ||
| message: Invalid address provided. | ||
| entity: Address | ||
| CheckAddressTaxabilityBadRequestResponse: | ||
| summary: Bad Request address check taxability response | ||
| description: The request provided for check taxability was Invalid/contained invalid data | ||
| value: | ||
| errors: | ||
| - code: INVALID_DATA | ||
| message: Empty address provided. |
There was a problem hiding this comment.
in the 400 response example we should add invalid address example.
There was a problem hiding this comment.
line 2618 to 2620 is invalid address example.
Do you mean an example of an invalid addreess?
There was a problem hiding this comment.
I don't agree with 400 error code,
because -> The api is to validate address, and if api is sucessfull it should return 200
now the address invalid is part of the successful api call of this api only..
400 is when the api itself fails because of invalid input !
| errors: | ||
| - code: INVALID_DATA | ||
| message: Invalid address provided. | ||
| entity: Address | ||
| CheckAddressTaxabilityBadRequestResponse: | ||
| summary: Bad Request address check taxability response | ||
| description: The request provided for check taxability was Invalid/contained invalid data | ||
| value: | ||
| errors: | ||
| - code: INVALID_DATA | ||
| message: Empty address provided. |
There was a problem hiding this comment.
I don't agree with 400 error code,
because -> The api is to validate address, and if api is sucessfull it should return 200
now the address invalid is part of the successful api call of this api only..
400 is when the api itself fails because of invalid input !
3 participants
Invalid address response should be returned as 400 only, not 200