Repository navigation
fix(rag): derive readiness from complete document embeddings - #148
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness could become stale after replacing some vectors, and a batch covering several documents could assign its first model to all of them. Direct chunk replacement also left old readiness behind.
Recompute each touched document from its complete chunk set. Only fully embedded, model-consistent documents are ready. Lock parent documents in sorted order before batched vector updates, and invalidate the parent before direct chunk replacement. The in-memory store follows the same transitions.
Validation on main plus this change:
No schema, retrieval ranking, vector-dimension policy or provider change. The PostgreSQL evidence is bounded concurrency coverage, not hosted configuration parity, soak testing or ambiguous-commit recovery. Readiness continues to mean complete non-null, consistent-model coverage, not universal stored-vector validity.