Repository navigation
Add Ruff linter and formatter - #17
Merged
Merged
Conversation
Member
Author
|
@jjmerchante , if you have a minute, can you review this PR? |
jjmerchante
self-requested a review
November 11, 2026 18:47
jjmerchante
requested changes
Nov 11, 2026
jjmerchante
left a comment
Contributor
There was a problem hiding this comment.
.flake8 is still in the repository
sduenas
force-pushed
the
ruff-pre-commit
branch
2 times, most recently
from
November 12, 2026 09:08
3a3cb24 to
5aea7f7
Compare
added 2 commits
November 12, 2026 10:09
Apply the formatter to the files of the repository. This deletes the unnecesarry flake8 package because its rules are also applied by the formatter. This commit also includes the installation of pre-commit. With pre-commit everytime a new commit is created, the formatter will run and correct the errors. Signed-off-by: Santiago Dueñas <sduenas@grimoirelab.org>
The linter and the formatter will execute every time the tests workflow is run. Signed-off-by: Santiago Dueñas <sduenas@grimoirelab.org>
sduenas
force-pushed
the
ruff-pre-commit
branch
from
November 12, 2026 09:09
5aea7f7 to
15b6cc8
Compare
Member
Author
|
@jjmerchante comments addressed |
jjmerchante
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we did in chaoss/grimoirelab-core#62, the idea is to automate formatting and linter tasks so we don't waste our time figuring out what style is best.
This PR adds Ruff to check as formatter and, with the help of
pre-commit, every time a new commit is created, the files will be formatted.CI has been also updated to check if the format is correct after a PR is created.