Quantity initialization does not call jax.numpy.asarray when mantissa is a Python number

[chaoming0625]

This pull request includes a change to the brainunit/_base.py file. The change involves modifying the initialization of the mantissa variable to skip the conversion to a jnp.array when a specific data type (dtype) is not provided.

• brainunit/_base.py: Commented out the line converting mantissa to a jnp.array with a specified dtype and directly assigned the mantissa variable instead.

Summary by Sourcery

Bug Fixes:

• Fixed a bug where Quantity initialization unnecessarily called jax.numpy.asarray when mantissa was a Python number and no explicit dtype was provided.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the initialization of the mantissa variable in the Quantity class. The change skips the conversion of mantissa to a jnp.array when a specific data type (dtype) is not provided. This is done by commenting out the line mantissa = jnp.array(mantissa, dtype=dtype) and directly assigning the mantissa variable instead.

Sequence diagram for Quantity initialization with mantissa as Python number

sequenceDiagram
    participant Client
    participant Quantity

    Note over Client,Quantity: Before Change
    Client->>Quantity: __init__(mantissa=number, dtype=None)
    Quantity->>Quantity: Convert mantissa to jnp.array
    Quantity-->>Client: Initialized Quantity

    Note over Client,Quantity: After Change
    Client->>Quantity: __init__(mantissa=number, dtype=None)
    Quantity->>Quantity: Use mantissa directly
    Quantity-->>Client: Initialized Quantity

Loading

Class diagram showing Quantity initialization change

classDiagram
    class Quantity {
        -mantissa
        +__init__(mantissa, dtype=None)
    }
    note for Quantity "When dtype is None and mantissa is a number,
mantissa is used directly without jnp.array conversion"

Loading

File-Level Changes

Change	Details	Files
Removed the conversion of mantissa to a jnp.array when dtype is not provided.	Commented out the line converting mantissa to a jnp.array with a specified dtype. Directly assigned the mantissa variable instead of converting it to a jnp.array.	brainunit/_base.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @chaoming0625 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Removing the jnp.array conversion could lead to type inconsistencies in the codebase. Please provide justification for why the array conversion needs to be skipped, ideally with test cases demonstrating the issue being fixed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}