Skip to content

chore: add linter to CI#29

Merged
estensen merged 1 commit intomainfrom
lint
Apr 1, 2025
Merged

chore: add linter to CI#29
estensen merged 1 commit intomainfrom
lint

Conversation

@estensen
Copy link
Contributor

@estensen estensen commented Apr 1, 2025

Merge after lints are fixed

➜  fiber-go git:(lint) ✗ golangci-lint run
client.go:175:10: Error return value of `c.Close` is not checked (errcheck)
                c.Close()
                       ^
client.go:181:10: Error return value of `c.Close` is not checked (errcheck)
                c.Close()
                       ^
client.go:187:10: Error return value of `c.Close` is not checked (errcheck)
                c.Close()
                       ^
client_test.go:35:22: Error return value of `client.Close` is not checked (errcheck)
                        defer client.Close()
                                          ^
reconnection_test.go:38:19: Error return value of `fiber.Close` is not checked (errcheck)
        defer fiber.Close()
                         ^
reconnection_test.go:91:18: Error return value of `fiber.conn.Close` is not checked (errcheck)
        fiber.conn.Close()
                        ^
compression.go:51:4: QF1008: could remove embedded field "Writer" from selector (staticcheck)
        z.Writer.Reset(w)
          ^
7 issues:
* errcheck: 6
* staticcheck: 1

@estensen
Copy link
Contributor Author

estensen commented Apr 1, 2025

These address the linter fails
#30
#31

@estensen estensen marked this pull request as ready for review April 1, 2025 10:56
@estensen estensen merged commit 1f44fc6 into main Apr 1, 2025
2 checks passed
@estensen estensen deleted the lint branch April 1, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant