Open
Conversation
omegafrog
reviewed
Dec 20, 2024
omegafrog
left a comment
omegafrog
left a comment
There was a problem hiding this comment.
objectmapper를 이용해서 파일 영속화 관리의 힌트를 얻었습니다
Comment on lines
+15
to
+16
| private static final ObjectMapper objectMapper = new ObjectMapper(); | ||
| private static final ObjectWriter objectWriter = objectMapper.writerWithDefaultPrettyPrinter(); |
There was a problem hiding this comment.
ObjectMapper 사용해서 영속화를 쉽게 처리했군요. 깔끔해서 괜찮은 것 같아요
Comment on lines
+132
to
+139
| for (File file : files) { | ||
| try { | ||
| Quote quote = objectMapper.readValue(file, Quote.class); | ||
| quotes.add(quote); | ||
| } catch (IOException e) { | ||
| System.out.println("파일 로드 실패: " + file.getName()); | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분도 참고해서 개선해보겠습니다. objectmapper를 잘 사용해야겠네요
thisis-joe
referenced
this pull request
in thisis-joe/code-review
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
스프링을 학습이 부족해 레벨10까지만 완료하였습니다.
src/main/java/noSpring 에 1~10단계까지 작성되어있습니다.
README.md 에 출력 결과 및 코드 설명 추가
src/main/java/Spring 에 Level11부터 작성 예정