Skip to content

[BE5] 신윤호#31

Open
messiteacher wants to merge 1 commit intochacha86:mainfrom
messiteacher:develop
Open

[BE5] 신윤호#31
messiteacher wants to merge 1 commit intochacha86:mainfrom
messiteacher:develop

Conversation

@messiteacher
Copy link

tdd를 제외한 13단계까지 구현 완료

구현

  • crud 기능

TODO

  • 페이징 기능
  • TDD

Comment on lines +84 to +88
WiseSaying wiseSaying = wiseSayingService.findById(id);
if (wiseSaying == null) {
System.out.println(id + "번 명언은 존재하지 않습니다.");
return ;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검색 결과로 null이 반환될 수 있는 경우 Repository에서 Optional으로 반환하는 것도 고려해볼만 할 것 같습니다 😀

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요 좋은 의견 감사합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants