web: Share Docker connection for exit-code inspection#49
Merged
Conversation
…n test Address PR cgwalters#47 review feedback: create the bollard Docker connection once before the enrichment future and reuse it for exit-code inspection, rather than opening a redundant second connection afterward. Add an integration test that exercises the full diagnostics pipeline by creating a pod without mock-agent mode so the agent container hits the pre-flight check (exit 42). This required adding start_without_mock() and create_pod_expect_degraded() to DevaipodHarness. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: arewm <arewm@users.noreply.github.com>
The pre-flight check for the agent binary ran after waiting for the state file, which meant a container with a missing binary would block indefinitely instead of failing fast. Move the check earlier so the container exits with code 42 immediately, putting the pod into Degraded state where the diagnostics pipeline can surface it. The integration test was also using the default test image (ghcr.io/bootc-dev/devenv-debian) which ships opencode, so the pre-flight check always passed. Switch to devcontainers/base:ubuntu which has git but not opencode. Assisted-by: Claude Code (claude-opus-4-6) Signed-off-by: arewm <arewm@users.noreply.github.com>
cgwalters
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address PR #47 review feedback: create the bollard Docker connection once before the enrichment future and reuse it for exit-code inspection, rather than opening a redundant second connection afterward.
Add an integration test that exercises the full diagnostics pipeline by creating a pod without mock-agent mode so the agent container hits the pre-flight check (exit 42). This required adding start_without_mock() and create_pod_expect_degraded() to DevaipodHarness.
Assisted-by: OpenCode (claude-opus-4-6)