change name and add application date to the edit detail

cfpb · Nov 18, 2020 · 1d9d000 · 1d9d000
1 parent f2ddb60
commit 1d9d000
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/common/src/main/resources/reference.conf b/common/src/main/resources/reference.conf
@@ -163,8 +163,8 @@ hmda {
       irsGroup = ${?KAFKA_IRS_GROUP}
       institutionsGroup = "institutions-group"
       institutionsGroup = ${?KAFKA_INSTITUTIONS_GROUP}
-      submissionErrorsGroup = "submission-errors-group"
-      submissionErrorsGroup = ${?KAFKA_SUBMISSION_ERRORS_GROUP}
+      submissionErrorsGroup = "triggered-quality-edits-group"
+      submissionErrorsGroup = ${?TRIGGERED_QUALITY_EDITS_GROUP}
     }
   }
 }

diff --git a/hmda-sql-doc/submission-errors.sql → hmda-sql-doc/triggered_quality_edits.sql b/hmda-sql-doc/submission-errors.sql → hmda-sql-doc/triggered_quality_edits.sql
@@ -1,4 +1,4 @@
-CREATE TABLE submission_errors(
+CREATE TABLE triggered_quality_edits(
     lei               VARCHAR,
     period            VARCHAR,
     sequence_number   INT,
@@ -7,5 +7,5 @@ CREATE TABLE submission_errors(
     loan_data         TEXT ARRAY,
     created_date      TIMESTAMP,
     updated_date      TIMESTAMP,
-    CONSTRAINT submission_errors_pkey PRIMARY KEY (lei, period, sequence_number, edit_name)
+    CONSTRAINT triggered_quality_edits_pkey PRIMARY KEY (lei, period, sequence_number, edit_name)
 );
diff --git a/submission-errors/src/main/resources/application.conf b/submission-errors/src/main/resources/application.conf
@@ -33,7 +33,7 @@ dbconfig {
   database = "hmda"
   database = ${?PG_DATABASE}
 
-  table = "submission_errors"
+  table = "triggered_quality_edits"
   table = ${?PG_TABLE}
 
   user = "postgres"

diff --git a/submission-errors/src/main/scala/hmda/submissionerrors/streams/ErrorLines.scala b/submission-errors/src/main/scala/hmda/submissionerrors/streams/ErrorLines.scala
@@ -21,7 +21,7 @@ import scala.concurrent.Future
 object ErrorLines {
   type RawLine = String
 
-  final case class RowLoanData(uli: String, actionTaken: Int, actionTakenDate: Int) {
+  final case class RowLoanData(uli: String, actionTaken: Int, actionTakenDate: Int, applicationDate: String) {
     override def toString: String = s"$uli:$actionTaken:$actionTakenDate``"
   }
 
@@ -65,7 +65,7 @@ object ErrorLines {
           case Some(editNames) =>
             // only parse the line if we found that there was an error associated with it
             val lar      = LarCsvParser(rawData).getOrElse(LoanApplicationRegister())
-            val loanData = RowLoanData(lar.loan.ULI, lar.action.actionTakenType.code, lar.action.actionTakenDate)
+            val loanData = RowLoanData(lar.loan.ULI, lar.action.actionTakenType.code, lar.action.actionTakenDate, lar.loan.applicationDate)
             editNames.foldLeft(acc) { (acc, nextEditName) =>
               val updatedErrorListForEdit = acc.getOrElse(nextEditName, Vector.empty[RowLoanData]) :+ loanData
               acc + (nextEditName -> updatedErrorListForEdit)

diff --git a/submission-errors/src/test/resources/bootstrap.sql b/submission-errors/src/test/resources/bootstrap.sql
@@ -1,4 +1,4 @@
-CREATE TABLE submission_errors(
+CREATE TABLE triggered_quality_edits(
     lei               VARCHAR,
     period            VARCHAR,
     sequence_number   INT,
@@ -7,5 +7,5 @@ CREATE TABLE submission_errors(
     loan_data         TEXT ARRAY,
     created_date      TIMESTAMP,
     updated_date      TIMESTAMP,
-    CONSTRAINT submission_errors_pkey PRIMARY KEY (lei, period, sequence_number, edit_name)
+    CONSTRAINT triggered_quality_edits_pkey PRIMARY KEY (lei, period, sequence_number, edit_name)
 );
diff --git a/...test/scala/hmda/submissionerrors/repositories/PostgresSubmissionErrorRepositorySpec.scala b/...test/scala/hmda/submissionerrors/repositories/PostgresSubmissionErrorRepositorySpec.scala
@@ -20,7 +20,7 @@ class PostgresSubmissionErrorRepositorySpec
   "PostgresSubmissionErrorRepository" should "persist error data into the repository" in {
     // Note: dbConfig comes from EmbeddedPostgres
     val dbConfig     = PostgresSubmissionErrorRepository.config(dbHoconpath)
-    val repo         = PostgresSubmissionErrorRepository.make(dbConfig, "submission_errors")
+    val repo         = PostgresSubmissionErrorRepository.make(dbConfig, "triggered_quality_edits")
     val submissionId = SubmissionId("EXAMPLE-LEI", Period(2018, None), sequenceNumber = 1)
 
     repo.submissionPresent(submissionId).runSyncUnsafe() shouldBe false