Skip to content

fix(security): block unsafe inline stylesheets #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(security): block unsafe inline stylesheets #2618

wants to merge 1 commit into from
+1 −1

Conversation

contolini
Copy link
Member

Removes 'unsafe_inline' from the style_src nginx directive to prevent inline stylesheets from being loaded.

See #4529 and #2480

Changes

  • Updates nginx to block inline styles.

Testing

  1. Tests should pass against dev and everything should behave as expected.

billhimmelsbach
billhimmelsbach reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh this is a weird one, since everything works fine now with it removed? Did ya figure out why in the ticket screenshots it was broken?

@contolini
fix(security): block unsafe inline stylesheets
ed49820 
Removes 'unsafe_inline' from the style_src nginx directive to prevent
inline stylesheets from being loaded.

See https://ghe/HMDA-Operations/hmda-devops/issues/4529
Fixes #2480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@contolini @billhimmelsbach