Skip to content

fix(mlar): change MLAR file format, fix 2017 MLAR downloads #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(mlar): change MLAR file format, fix 2017 MLAR downloads #2571

wants to merge 3 commits into from
+12 −3

Conversation

contolini
Copy link
Member

@contolini contolini commented Aug 6, 2025 •
edited
Loading

Changes

  • Changes MLAR download file format from .csv to .txt
  • Fixes filenames of 2017 MLAR downloads.
  • Adds a test that confirms MLAR downloads aren't empty (and verifies the two above fixes).

Testing

  1. ModifiedLAR.spec.js cypress tests should pass.
  2. These two scenarios should no longer be happening.

Notes

  1. I'm validating that the downloaded files are MLAR-ish by checking if they have lots of pipes in them. It's pretty silly and lmk if you can think of a smarter way.

@contolini
Confirm that MLAR files download properly
0e59afd 
After searching for MLAR files from each year, open them and confirm
they're not empty and are MLAR-ish (lots of pipes in the file).

Fixes #2522
@contolini
Download MLAR files as text files instead of CSVs
50615a0 
MLAR files are supposed to be .txt files and not .csv files.
Their contents are pipe-delimited text.

Fixes #2569
@contolini
Fix MLAR download filename for 2017
8cad027 
2017 has no `institution.lei` value so use the normalized institution
ID when interpolating the download file name.

Fixes #2570
@billhimmelsbach
Copy link
Contributor

Let's wait to merge this in till ya get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@contolini @billhimmelsbach