Allow the websocket message bus to bind a tcp:// address#424
Open
mcoughlin wants to merge 2 commits into
Open
Conversation
Contributor
|
Wondering why we don't just standardize on using ports internally too, then we can avoid the munging. Note we have two servers here: message bus + websocket server. The websocket server is, in fact, just a client of the message bus. The message bus should be straightforward: runs a single instance, and exposes two ports — one to receive messages, one to publish messages. The websocket server connects to the port where messages are published, and forwards them to the browser. The app connects to the port where messages are received, and pushes them onto the bus. So, let's just use TCP for everything—simpler? ports:
websocket: ...
message_bus_receive: ...
message_bus_publish: ...
hosts:
message_bus: 127.0.0.1Flow will push to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the websocket message bus to bind a tcp:// address (next step in Kubernetes readiness).