Improve makefile bundle management#418
Merged
Theodlz merged 4 commits intoApr 1, 2026
Merged
Conversation
…t and clean to rm -rf static/build to allow using content hashes in the name.
…s with names like main.bundle.js or main.[hash].bundle.js.
Contributor
Author
Theodlz
approved these changes
Apr 1, 2026
Theodlz
left a comment
Theodlz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one minor question
Contributor
|
Sorry folks, I was out on leave. |
Contributor
|
Changes look good though, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have opened a PR (skyportal/skyportal#6034) on SkyPortal to switch the bundle cache key to use a content hash instead of the skyportal version hash. As part of this, I also updated Baselayer to support hashed bundle filenames.