Add CustomClientCertificateDuration

[volkorny]

Add CustomClientCertificateDuration

Hello Team,

This PR is not yet ready for merging, as I still need to add the corresponding tests and update the Helm chart. However, I’d appreciate your feedback on the current changes before proceeding further.

In our service mesh, we aim to increase the certificate duration beyond 24 hours. I noticed a similar request in cert-manager/istio-csr issue #176.

Could you please review my changes and let me know if they seem reasonable?

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thatsmrtalbot for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cert-manager-prow]

Hi @volkorny. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[SgtCoDFish]

/ok-to-test

Hey, thanks for raising this. I'm heading out for the holidays soon and won't be back until the new year. This does seem a reasonable thing to add. In any case, I'll enable testing so you're able to use the CI properly!

Thanks for the contribution - if you need a review, cert-manager slack is probably the place to ask!

[cert-manager-prow]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• a946134 Add CustomClientCertificateDuration
• b7fde49 rename to ClientCertificateDuration
• 75a0995 add changes to helm templates
• eb5f0dd minor fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[volkorny]

/retest

[volkorny]

I have recreated PR here: #469