Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pe - machine type field #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pe - machine type field #194

wants to merge 1 commit into from

Conversation

wesinator
Copy link
Contributor

No description provided.

@cert-ee-raidar
Copy link
Contributor

Can you please add the purpose of this PR.
Add why the change is needed in few sentences and why current solution is lacking

@wesinator
Copy link
Contributor Author

it's not critical, but it adds an additional field to the output of PE parsing. This way the PE parsing isn't 'hiding' info that is available from the pefile library. Machine type is one data point for static analysis and binary triage.

@cert-ee-raidar
Copy link
Contributor

Thank you for the clarification.
I will get back to this PR in about a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesinator @cert-ee-raidar