Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): add support for Python 3.13 #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build(python): add support for Python 3.13 #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
runs-on: ubuntu-24.04
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the CI failures for py313 are the same as for py312 and are related to the recent change in the CERN Open Data portal's handling of files attached to records via file indexes.

Test results for Python 3.13:

$ tox -e py313
FAILED tests/test_cli_download_files.py::test_dry_run_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in '\n'
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand_verbose - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in ''
FAILED tests/test_metadater.py::test_get_metadata_from_filter_metadata_two - assert 1 == 0
=============================================================================================== 5 failed, 65 passed, 10 skipped in 7.96s ===============================================================================================
py313: exit 1 (8.22 seconds) cernopendata-client> pytest pid=685218
  py313: FAIL code 1 (14.79=setup[6.57]+cmd[8.22] seconds)
  evaluation failed :( (14.84 seconds)

Test results for Python 3.13:

$ tox -e py313
FAILED tests/test_cli_download_files.py::test_dry_run_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in '\n'
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand_verbose - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in ''
FAILED tests/test_metadater.py::test_get_metadata_from_filter_metadata_two - assert 1 == 0
=============================================================================================== 5 failed, 65 passed, 10 skipped in 7.87s ===============================================================================================
py312: exit 1 (8.15 seconds) cernopendata-client> pytest pid=686540
  py312: FAIL code 1 (12.79=setup[4.64]+cmd[8.15] seconds)
  evaluation failed :( (12.84 seconds)

"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python",
"Topic :: Internet :: WWW/HTTP :: Dynamic Content",
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ envlist =
py310
py311
py312
py313

[testenv]
deps =
Expand Down
Loading