Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(commitlint): addition of commit message linter (#143) #143

Merged
merged 6 commits into from
Aug 23, 2024
Merged

ci(commitlint): addition of commit message linter (#143) #143

merged 6 commits into from
Aug 23, 2024

Conversation

tiborsimko
Copy link
Member

@tiborsimko tiborsimko commented Aug 22, 2024 •
edited
Loading

  • build(docker): upgrade to Ubuntu 24.04 and Python 3.12
  • ci(actions): upgrade to Ubuntu 24.04 and Python 3.12
  • build(python): drop support for Python 3.6 and 3.7
  • ci(actions): update GitHub actions due to Node 16 deprecation
  • ci(release-please): initial Release Please configuration
  • ci(commitlint): addition of commit message linter

@tiborsimko
ci(commitlint): addition of commit message linter (cernopendata#143)
e01fff8 
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(release-please): initial configuration (cernopendata#143)
4d6f87a
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(release-please): initial configuration (cernopendata#143)
6649ab5
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(actions): update GitHub actions due Node deprecation (cernopendata…
f06b202 
…#143)
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (a951321) to head (bac8200).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   80.36%   80.65%   +0.29%     
==========================================
  Files          12       12              
  Lines         718      729      +11     
==========================================
+ Hits          577      588      +11     
  Misses        141      141

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(actions): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143)
bfd637c
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
build(docker): upgrade to Ubuntu 24.04 LTS and Python 3.12 (cernopend…
30f3bda 
…ata#143)
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(release-please): initial Release Please configuration (cernopendat…
7428090 
…a#143)
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(actions): update GitHub actions due to Node 16 deprecation (cernop…
a57a9bc 
…endata#143)
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(actions): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143)
564c3b9
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
build(docker): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143
4b13628 
)
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(actions): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143)
1af1a4c
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
build(docker): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143
8dd894c 
)
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
build(python): drop support for Python 3.6 and 3.7 (cernopendata#143)
6e37dcc 
BREAKING CHANGE: Drops support for Python 3.6 and 3.7.
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
ci(actions): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143)
5d35e48
tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Aug 22, 2024
@tiborsimko
build(docker): upgrade to Ubuntu 24.04 and Python 3.12 (cernopendata#143
14cef8b 
)
@tiborsimko tiborsimko self-assigned this Aug 22, 2024
mdonadoni
mdonadoni approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiborsimko tiborsimko merged commit bac8200 into cernopendata:master Aug 23, 2024
15 checks passed
@tiborsimko tiborsimko deleted the commitlint branch August 23, 2024 09:28
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonadoni mdonadoni mdonadoni approved these changes

Assignees

@tiborsimko tiborsimko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiborsimko @mdonadoni