Skip to content

Commit

Permalink
Revert "[Secsss] Fix upcast array used in pointer arithmetics"
Browse files Browse the repository at this point in the history
This reverts commit 50209b3.
The fix is incorrect, as struct XrdSecsssRR_Data actually derives
from XrdSecsssRR_DataHdr, which introduces some members in between
such that prData.Data is not actually at the beginning of the struct,
but at some non-zero offset (i.e. different address than &prData).
  • Loading branch information
amadio committed Nov 29, 2024
1 parent 5310587 commit 9f74352
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/XrdSecsss/XrdSecProtocolsss.cc
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ int XrdSecProtocolsss::getCred(XrdOucErrInfo *einfo,

// Extract out the loginid. This messy code is for backwards compatibility.
//
bP = prData.Data; eodP = prData.Data + dLen;
bP = prData.Data; eodP = dLen + (char *)&prData;
while(bP < eodP)
{idType = *bP++;
if (!XrdOucPup::Unpack(&bP, eodP, &idP, idSz) || !idP || *idP == 0)
Expand Down

0 comments on commit 9f74352

Please sign in to comment.