[XrdPss] Fix potential null pointer dereference in copyCGI

cern-eos · Nov 26, 2024 · 9611aa2 · 9611aa2
1 parent 58bb106
commit 9611aa2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/XrdPss/XrdPssUrlInfo.cc b/src/XrdPss/XrdPssUrlInfo.cc
@@ -54,15 +54,15 @@ int copyCGI(const char *cgi, char *Buff, int Blen)
 {
    int n;
 
-//std::cerr <<"PSS cgi IN: '" <<cgi <<"' " <<strlen(cgi) <<'\n' <<std::flush;
+   if (!cgi) {*Buff = 0; return 0;}
 
 // Skip over initial ampersands
 //
    while(*cgi == '&' && *cgi) cgi++;
 
 // Check if there is anything here
 //
-   if (!cgi || *cgi == 0) {*Buff = 0; return 0;}
+   if (*cgi == 0) {*Buff = 0; return 0;}
 
 // Copy out all variables omitting the ones that cause trouble
 //