XrdApps::JCache: handle incomplete reads in vector cache

cern-eos · Jun 10, 2024 · 0e27a6c · 0e27a6c
1 parent b8c8af9
commit 0e27a6c
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/XrdApps/XrdClJCachePlugin/vector/XrdClVectorCache.cc b/src/XrdApps/XrdClJCachePlugin/vector/XrdClVectorCache.cc
@@ -247,6 +247,19 @@ bool VectorCache::retrieve() const {
     std::ifstream inFile(fileName, std::ios::binary);
     if (inFile.is_open()) {
         inFile.read((char*)data, fileInfo.st_size);
+	if (inFile.fail()) {
+	  if (verbose) {
+	    std::cerr << "error: failed to read cached data" << std::endl;
+	  }
+	} else {
+	  std::streamsize bytesRead = inFile.gcount();
+	  if (bytesRead != fileInfo.st_size) {
+	    if (verbose) {
+	      std::cerr << "error: read only " << bytesRead << " bytes instead of " << fileInfo.st_size << " !"<< std::endl;
+	    }
+	    return false;
+	  }
+	}
         inFile.close();
         return true;
     } else {