services/kill.py: Allow admins to kill any run #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamoltat
requested changes
Jul 17, 2024
Member
kamoltat
left a comment
kamoltat
left a comment
There was a problem hiding this comment.
Minor coding style comments and env variable stuff, other than that, everything else looks fine
kamoltat
previously approved these changes
Sep 30, 2024
Member
kamoltat
left a comment
kamoltat
left a comment
There was a problem hiding this comment.
Just a little nit, otherwise I think everything else looks great
Signed-off-by: Vallari Agrawal <[email protected]>
"scheduled_<username>@teuthology" is the default owner name if run is scheduled from teuthology CLI tool. This commit allows users of same github username to recognize it as their jobs. Also fix how run_owner is determined. In teuthology, runs ownership is deteremined by job's "owner" and not run's "user" value. Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
And decode kill-cmd output logs. Signed-off-by: Vallari Agrawal <[email protected]>
For example, value of "--preserve-queues" is boolean in /kill request schema. If it's true, add it to the kill cmd, otherwise don't add the flag. Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
Signed-off-by: Vallari Agrawal <[email protected]>
VallariAg
force-pushed
the
admin-kill
branch
from
2c7f0e6 to
8f8ea00
Compare
kamoltat
previously approved these changes
Nov 25, 2024
Member
kamoltat
left a comment
kamoltat
left a comment
There was a problem hiding this comment.
minor comment, other than that it is good to go!
Errors are logged for HTTPError and Exception, also log them for HTTPException before raising the exception. Signed-off-by: Vallari Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admins are users who are on "Ceph" team on github.
This PR also improves error handling for kill route.
Contribution Guidelines
To sign and test your commits, please refer to Contibution guidelines.
Checklist