Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Update jaeger-client-go to v2.29.0 #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nhatthm
Copy link

@nhatthm nhatthm commented May 21, 2021

Update jaeger-client-go to v2.29.0 due to the breaking changes

@google-cla
Copy link

google-cla bot commented May 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nhatthm
Copy link
Author

nhatthm commented May 21, 2021

@googlebot I signed it!

@nhatthm
Copy link
Author

nhatthm commented May 21, 2021

Blocked by #18

@dcormier
Copy link

dcormier commented Jun 10, 2021

It would be nice to move it forward so we can safely update our dependencies.

For anyone trying to update their dependencies and seeing errors like this:

# contrib.go.opencensus.io/exporter/jaeger
../../../../pkg/mod/contrib.go.opencensus.io/exporter/[email protected]/agent.go:76:10: a.client.SeqId undefined (type *agent.AgentClient has no field or method SeqId)
../../../../pkg/mod/contrib.go.opencensus.io/exporter/[email protected]/agent.go:77:30: not enough arguments in call to a.client.EmitBatch
        have (*jaeger.Batch)
        want (context.Context, *jaeger.Batch)
../../../../pkg/mod/contrib.go.opencensus.io/exporter/[email protected]/jaeger.go:361:21: not enough arguments in call to obj.Write
        have (*thrift.TBinaryProtocol)
        want (context.Context, thrift.TProtocol)

You can work around it by adding this to your go.mod:

// TODO: Remove this once this PR is merged and a new version (> 0.2.1) is released.
// https://github.com/census-ecosystem/opencensus-go-exporter-jaeger/pull/17
replace github.com/uber/jaeger-client-go => github.com/uber/jaeger-client-go v2.28.0+incompatible

Shouldn't need it once this PR is merged and a new version is released.

@lelvisl
Copy link

lelvisl commented Aug 13, 2021

will this dependency be updated? or the repository is abandoned?
#19

@lelvisl
Copy link

lelvisl commented Aug 13, 2021

Kindly pinging @rghetia @songy23 to help with a merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants