refactor(types): Add ToProto method for RowProof struct #1600
+261
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract ToProto functionality from ShareProof into a dedicated method for RowProof to improve code modularity and maintainability. This change makes the conversion between domain and protobuf types more consistent across the codebase.
VolodymyrBg
requested review from
cmwaters and
rach-id
and removed request for
a team
evan-forbes
previously requested changes
Feb 3, 2025
|
@evan-forbes added tests |
rootulp
changed the title
rootulp
previously approved these changes
Feb 4, 2025
rach-id
reviewed
Feb 4, 2025
Yes. |
|
@rach-id Done |
rootulp
previously approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dedicated ToProto() method for the RowProof struct, addressing a TODO comment in the codebase. The change improves code modularity and maintainability by extracting the protobuf conversion logic from ShareProof.ToProto() into a separate method.
Key Changes:
Files Modified:
types/row_proof.go: Added new ToProto() method
types/share_proof.go: Updated to use new RowProof.ToProto()
This is a small, focused change that improves code organization without changing any functionality. The conversion logic remains the same but is now properly encapsulated in the RowProof struct.
PR checklist