-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable celestia-app to run in Vercel Go runtime #4428
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the initialization logic in the application to improve compatibility with Vercel’s Go runtime environment, where the user's home directory may not be set. In the Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Going to add one commit to this PR to bump to the latest celestiaorg/ibc-go release which contains a fix for the same issue. |
Closes #4427
The only important change is ignoring the error returned by
os.UserHomeDir()
. The rest of the diff is a refactor for legibility. I re-ordered celestiaHome in arguments and test cases first because it takes precedence over userHome.cc: @lzrscg