-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: grammar and spelling errors #4327
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request makes small non-functional documentation updates. In the proto file, the spacing in the comment for the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
specs/src/parameters_v3.md (1)
62-62
: Consider adding a comma for better readability.Add a comma before "which" to improve grammar in the description.
-| packetforwardmiddleware.FeePercentage | 0 | % of the forwarded packet amount which will be subtracted and distributed to the community pool. | True | +| packetforwardmiddleware.FeePercentage | 0 | % of the forwarded packet amount, which will be subtracted and distributed to the community pool. | True |🧰 Tools
🪛 LanguageTool
[uncategorized] ~62-~62: Possible missing comma found.
Context: ... | % of the forwarded packet amount which will be subtracted and distribute...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
proto/celestia/core/v1/da/data_availability_header.proto
(1 hunks)specs/src/parameters_v3.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- proto/celestia/core/v1/da/data_availability_header.proto
🧰 Additional context used
🪛 LanguageTool
specs/src/parameters_v3.md
[uncategorized] ~62-~62: Possible missing comma found.
Context: ... | % of the forwarded packet amount which will be subtracted and distribute...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
specs/src/parameters_v3.md (1)
62-62
: LGTM! Spelling correction looks good.The spelling correction from "packetfowardmiddleware" to "packetforwardmiddleware" is accurate.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~62-~62: Possible missing comma found.
Context: ... | % of the forwarded packet amount which will be subtracted and distribute...(AI_HYDRA_LEO_MISSING_COMMA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to regenerate the proto files by running make proto-gen
or revert this change altogether
changed:
RowRoot_j = - RowRoot_j =
packetfowardmiddleware - packetforwardmiddleware