Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to Go 1.23.6 #4321

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Feb 11, 2025

Unblocks #4316

@rootulp rootulp self-assigned this Feb 11, 2025
@rootulp rootulp marked this pull request as ready for review February 11, 2025 16:48
@rootulp rootulp requested a review from a team as a code owner February 11, 2025 16:48
@rootulp rootulp requested review from cmwaters and evan-forbes and removed request for a team February 11, 2025 16:48
@rootulp rootulp enabled auto-merge (squash) February 11, 2025 16:48
Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

📝 Walkthrough

Walkthrough

This pull request upgrades the Golang version used throughout the project from 1.23.5 to 1.23.6. The changes update the version in the Makefile, README, Dockerfiles, go.mod, go.work.example, and a test module’s go.mod. There are no modifications to logic, control flow, or error handling.

Changes

File(s) Change Summary
Makefile, README.md Update Golang version from v1.23.5 to v1.23.6: the Makefile variable and README installation instructions are revised.
docker/Dockerfile, docker/txsim/Dockerfile Update builder/base image tag from docker.io/golang:1.23.5-alpine3.20 to docker.io/golang:1.23.6-alpine3.20.
go.mod, go.work.example, test/interchain/go.mod Update Go version in module files from 1.23.5 to 1.23.6.

Possibly related PRs

Suggested labels

backport:v3.x

Suggested reviewers

  • cmwaters
  • ninabarbakadze
  • evan-forbes
  • rach-id

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a99340 and a661833.

📒 Files selected for processing (7)
  • Makefile (1 hunks)
  • README.md (1 hunks)
  • docker/Dockerfile (1 hunks)
  • docker/txsim/Dockerfile (1 hunks)
  • go.mod (1 hunks)
  • go.work.example (1 hunks)
  • test/interchain/go.mod (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • README.md
  • test/interchain/go.mod
  • go.mod
  • go.work.example
  • docker/txsim/Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary
🔇 Additional comments (2)
docker/Dockerfile (1)

7-7: Verify Go version and Docker image availability.

Let's verify that Go 1.23.6 is a valid version and the Docker image exists.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Verify if the Docker image exists and can be pulled
docker pull docker.io/golang:1.23.6-alpine3.20 2>&1 || echo "Image not found"

Length of output: 186


🌐 Web query:

What is the latest version of Go? Is version 1.23.6 valid?

💡 Result:

The latest stable version of Go as of February 11, 2025 is 1.23.6, released on February 4, 2025[1][2]. This minor revision includes security fixes for the crypto/elliptic package and bug fixes for both the compiler and go command[1].

Version Validity

  • Yes, version 1.23.6 is valid and currently supported:
    • Part of the Go 1.23 release series first launched in August 2024[5][8]
    • Follows standard Go release policy where major versions receive updates until two newer majors exist[1]
    • Contains security patches critical for production environments[1]

Current Release Details

Version Release Date Key Updates
1.23.6 Feb 4, 2025 • Security: crypto/elliptic
• Compiler/go command fixes
1.23.x Aug 2024-Feb 2025 • Iterators via for/range
• Toolchain improvements[5][8]

The next major version (Go 1.24) remains in development with an expected February 2025 release[10]. Version selection depends on requirements:

  • Production systems: Recommended to use latest patch (1.23.x)
  • Experimental features: Consider nightly builds for upcoming features

Package managers like Chocolatey show 1538 downloads of v1.23.6 within its first week of availability[2], indicating active adoption by developers working with secure cryptographic implementations and compiler toolchains[7].

Citations:


Verified: Go version and Docker image tagging are correct.

  • Go 1.23.6 is a valid, current patch version as confirmed by recent web sources.
  • The image tag docker.io/golang:1.23.6-alpine3.20 follows the official naming convention; the failure of the docker pull test was due to the absence of Docker in the testing environment rather than the image’s non-existence.
Makefile (1)

12-12: Verify goreleaser-cross image availability.

Let's verify that the goreleaser-cross image with the new Go version exists.

❌ Verification inconclusive

🏁 Script executed:

#!/bin/bash
# Verify if the goreleaser-cross image exists and can be pulled
docker pull ghcr.io/goreleaser/goreleaser-cross:v1.23.6 2>&1 || echo "Image not found"

Length of output: 195


Let's try an alternative approach using the GHCR API via curl (instead of the unavailable docker command) to verify if the image exists. Please run the script below:


🏁 Script executed:

#!/bin/bash
# Use the Docker Registry HTTP API to check for the existence of the manifest
status_code=$(curl -s -o /dev/null -w "%{http_code}" https://ghcr.io/v2/goreleaser/goreleaser-cross/manifests/v1.23.6)
echo "HTTP Status Code: $status_code"
if [ "$status_code" -eq 200 ]; then
    echo "Image exists."
else
    echo "Image does not exist."
fi

Length of output: 252


Let's try adding the required Accept header so that we query for the Docker manifest in the expected format. Please run the updated script:


🏁 Script executed:

#!/bin/bash
# Check for the existence of the goreleaser-cross image using the expected Accept header.
status_code=$(curl -s -H "Accept: application/vnd.docker.distribution.manifest.v2+json" -o /dev/null -w "%{http_code}" https://ghcr.io/v2/goreleaser/goreleaser-cross/manifests/v1.23.6)
echo "HTTP Status Code: $status_code"
if [ "$status_code" -eq 200 ]; then
    echo "Image exists."
else
    echo "Image does not exist."
fi

Length of output: 318


Action Required: Ensure Authenticated Verification of the Goreleaser-Cross Image

The API call without authentication returned a "401 Unauthorized" code. This indicates that unauthenticated requests aren’t enough to confirm whether ghcr.io/goreleaser/goreleaser-cross:v1.23.6 exists. Please verify this image using authenticated requests (for example, by logging in via Docker or using a GitHub token) or through your CI/CD pipeline.

  • Double-check that an authenticated docker pull (or similar) succeeds.
  • Confirm that the image is compatible with the current goreleaser configuration before merging.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp merged commit b41fa4f into celestiaorg:main Feb 12, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants