fix: upgrade to celestia-core v1.46.0-tm-v0.34.35

[rootulp]

The go version bumped because

go: github.com/celestiaorg/[email protected] requires go >= 1.23.5 (running go 1.23.4; GOTOOLCHAIN=local)

[rootulp]

Need to bump the Go version in a few other places

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request upgrades Golang version references and related dependencies across the repository. The changes update the Golang cross-compilation version, required Go version in documentation and work files, and the Docker base images in multiple Dockerfiles. Additionally, dependency versions are revised in the main and test Go module files. No changes affect the application’s runtime logic or control flow.

Changes

File(s)	Change Summary
Makefile, README.md, go.work.example	Updated Golang version references from 1.23.1 to 1.23.5 in build variables, installation documentation, and work example file.
docker/Dockerfile, docker/txsim/Dockerfile	Updated Golang builder base images from docker.io/golang:1.23.1-alpine3.20 to docker.io/golang:1.23.5-alpine3.20.
go.mod	Upgraded Go version from 1.23.1 to 1.23.5 and updated the github.com/tendermint/tendermint dependency from v1.45.0-tm-v0.34.35 to v1.46.0-tm-v0.34.35.
test/interchain/go.mod	Upgraded Go version from 1.23.1 to 1.23.5; updated github.com/celestiaorg/nmt from v0.22.2 to v0.23.0 and github.com/tendermint/tendermint from v1.45.0-tm-v0.34.35 to v1.46.0-tm-v0.34.35.

Possibly related PRs

• chore: upgrade to Go 1.23.1 #3848: Directly updates the GOLANG_CROSS_VERSION in the Makefile, matching the current change pattern.
• chore(deps): upgrade to Go 1.22.6 #3764: Involves similar updates to the Makefile and README.md regarding the Go version and build variables.
• chore(deps): upgrade to celestia-core v1.38.0 #3659: Updates dependency versions in the test/interchain/go.mod file, aligning with the dependency modifications in this PR.

Suggested reviewers

• cmwaters
• ninabarbakadze
• evan-forbes
• rach-id
• staheri14

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d43ec72 and 8c5c3a8.

⛔ Files ignored due to path filters (2)

• go.sum is excluded by !**/*.sum
• test/interchain/go.sum is excluded by !**/*.sum

📒 Files selected for processing (7)

• Makefile (1 hunks)
• README.md (1 hunks)
• docker/Dockerfile (1 hunks)
• docker/txsim/Dockerfile (1 hunks)
• go.mod (2 hunks)
• go.work.example (1 hunks)
• test/interchain/go.mod (3 hunks)

✅ Files skipped from review due to trivial changes (3)

• go.work.example
• README.md
• docker/txsim/Dockerfile

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test / test
• GitHub Check: Summary

🔇 Additional comments (6)

docker/Dockerfile (1)

7-7: Update Golang Builder Image Version
The ARG BUILDER_IMAGE is updated to use docker.io/golang:1.23.5-alpine3.20, which aligns with the new Go version requirement. Ensure that the new image tag is available and verified for stability.

test/interchain/go.mod (2)

3-4: Update Go Version in Module
The Go version has been bumped from the previous version to 1.23.5, ensuring consistency with the overall upgrade.

---

35-35: Update nmt Dependency Version
The indirect dependency github.com/celestiaorg/nmt is updated to v0.23.0. This change should be compatible with the rest of the dependency graph.

go.mod (2)

3-4: Bump Go Version in go.mod
The Go version is now set to 1.23.5, which aligns with the updated builder image and documentation.

---

260-261: Update Tendermint Dependency Reference
The replace statement now maps github.com/tendermint/tendermint to github.com/celestiaorg/celestia-core v1.46.0-tm-v0.34.35. Please verify that this updated dependency is fully compatible with the project’s expectations and integration tests.

Makefile (1)

12-12: Upgrade Golang Cross Compilation Version
The GOLANG_CROSS_VERSION variable is updated to v1.23.5. This change is consistent with the Go version update across the repository. Ensure that a corresponding Docker image tag exists for this version.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rach-id]

this release also includes celestiaorg/celestia-core#1595.

is this something we want to start releasing? cc @evan-forbes

[evan-forbes]

this release also includes celestiaorg/celestia-core#1595

ahhhh yeah we definitely can't include that, good eye @rach-id. let's isolate the smaller change first. then include that in the next bump.

waiting for a smaller change

[rootulp]

Closing in favor of #4287 which reverted a feature in celestia-core that we don't want to expedite through the deployment pipeline.