Fix aud validation #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Any plans to merge this PR anytime soon @cduvray? |
|
Stumbled upon this bug, too. Am I right that there's no way to disable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, actual behavior does not match the docs.
For
Validation's fieldaudit says: "If it contains a value, the validation will check that theaudclaim value is in the values provided.". Reading this, I assume that it will skip validation ofaudclaim if this option isNoneBut in reality, it will fail for any token if the
audisNone(because of validation logic insidejsonwebtokencrate)This PR fixes it by setting an appropriate option
validate_audfor validation options ofjsonwebtoken