Improve tile compressed pixel access API#38
Merged
bmatthieu3 merged 3 commits intomasterfrom Aug 26, 2025
Merged
Conversation
BinaryTableData is an enum that contains 2 variants: * The TableData traditional API * The TileCompressed variant containing Pixels data. Pixels is an enum that can contain U8, I16, I32, F32 uncompressed pixels. You get an iterator over the uncompressed native u8, i16, i32, f32 pixels.
Contributor
|
This looks good! I will test this out tonight once the kid is asleep. I like the API. |
Collaborator
Author
|
@Fingel - Ok nice, if it is ok for you I can merge it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked to #37
BinaryTableData is an enum that contains 2 variants:
@Fingel - here is a api I achieved to provide. There is still a match to do because binary table can also contain real tabular data and not only tile compressed pixel data (haha). For such tabular data (the BinaryTableData::TableData), a pixels method has no sense.
I do not achieve big performance improving. Still a ~10% speedup which is reasonable but I would have thought I would gain more.