fix(management): harden customer-apps list route (encode TSG path segment)#189
Merged
Merged
Conversation
Wrap the TSG path segment in encodeURIComponent so a TSG ID with URL-reserved characters cannot corrupt the request URL. Expand list tests to assert offset/limit query params, a populated PaginatedCustomerAppObject round-trip, and the encoding regression. Closes #188
This was referenced Jul 9, 2026
Merged
cdot65
added a commit
that referenced
this pull request
Jul 9, 2026
- feat(red-team): Network Broker channel sub-client (#187) - feat(red-team): supported-languages and target-profile error-log endpoints (#193) - feat(model-security): read-only models sub-client (#195) - fix(management): percent-encode TSG ID in customer-apps list path (#189) - fix(red-team): correct Network Broker ChannelStats field names (#199)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188
What
Gap analysis against
specs/mgmt_service_docs.yamlconfirmed the customer-apps list route is already spec-compliant. This PR applies the one real improvement found: percent-encode the TSG ID in the list request path so a TSG ID containing URL-reserved characters can't corrupt the URL (other methods pass ids via query params, which are already encoded). Also expands the thin list test.Changes
customerApps.list()wraps the TSG path segment inencodeURIComponent.offset/limitquery params (default + explicit), round-trip a populatedPaginatedCustomerAppObject(customer_appId,cloud_provider,environment,api_keys_dp_info[],next_offset), and a percent-encoding regression.Verification
format:check,lint,typecheck,preflight(0 unacknowledged drift), full Vitest suite pass locally; pre-commit hook green.Non-breaking (patch). No behavior change for numeric TSG IDs.
🤖 Generated with Claude Code