fix: download template crash (getToken undefined)#68
Merged
Conversation
The downloadTemplate workaround accesses SDK internals (customAttacks.oauthClient.getToken) that no longer exist in the current SDK version. Replace with a direct OAuth token fetch using the client credentials from the constructor options.
SDK 0.8.3 fixes downloadTemplate to return CSV string directly. Drop the 30-line OAuth+raw-fetch workaround, delegate straight to the SDK. Update test to mock the SDK call instead of the removed internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airs redteam prompt-sets download <uuid>crashes with:The existing workaround in
promptsets.tsaccessesthis.client.customAttacks.oauthClient.getToken()which no longer exists in the current SDK version. This replaces it with a direct OAuth token fetch using the client credentials passed to the constructor, which doesn't depend on SDK internals.Related: cdot65/prisma-airs-sdk#77