fix(redteam): derive attack successful from threat field#219
Merged
Conversation
The listAttacks normalizer was reading `a.successful` — a field the API doesn't return. As a result every attack rendered as `BLOCKED` even when `threat: true` (bypassed). Derive successful from `a.threat` so the report --attacks pretty output labels outcomes correctly. Closes #205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
airs redteam report <jobId> --attacksprintedBLOCKEDfor every attack regardless of outcome.listAttacksnormalizer atsrc/airs/redteam.ts:467lifteda.successful— a field the API doesn't return perairs --debugcapture. Result was alwaysundefined(falsy) → renderer always pickedBLOCKED.successfulfroma.threatin the normalizer. Renderer logic unchanged (was already correct given a correctsuccessfulvalue).listAttackstest mocks to reflect real API shape (threatinstead of stalesuccessful).Test plan
listAttackstest now fails (mocks switched tothreat); new test confirms missingthreat→successful: false; renderer regression tests for BYPASSED/BLOCKEDpnpm lintcleanpnpm tsc --noEmitcleanpnpm test685 passedpnpm docs:checkcleanCloses #205