fix(dlp): lazy-load docx to silence localStorage warning on every command#218
Merged
cdot65 merged 1 commit intoMay 28, 2026
Merged
Conversation
cdot65
added a commit
that referenced
this pull request
May 28, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lazy-load the
docxdependency so it only loads when DOCX output is actually generated.Why
docxwas imported eagerly insrc/dlp/generate/docx.tsandsrc/dlp/embed/docx.ts. Because the command tree is built at startup,docxloaded on everyairscommand. Its bundled browserify polyfills pull inutil-deprecate's browser shim, which readslocalStorageat import time. On Node 22+ (seen on Node 25) that triggers:so the warning printed on every command (scan, profiles, redteam, etc.), not just DLP file generation.
Fix
Defer the
docximport into the DOCX builders viaawait import('docx'):src/dlp/generate/docx.ts- import moved inside the (already-async)docx()builder.src/dlp/embed/docx.ts- import moved insidebuild(); the technique embedders now pass plain data instead of pre-constructedParagraphs, so no module-leveldocxreference remains.docx(and the warning) now load only whendlp-genactually produces DOCX. Unrelated commands are warning-free and start slightly faster.Testing
pnpm buildclean,pnpm lint(biome) cleanpnpm test: full unit suite passesairs runtime profiles listandruntime scanemit 0 localStorage warnings;dlp-genDOCX output still works and the DOCX unit tests passChangeset included (patch).