feat: add a subset of properties for stackset stack manipulation#120
Open
arrjay wants to merge 3 commits into
Open
feat: add a subset of properties for stackset stack manipulation#120arrjay wants to merge 3 commits into
arrjay wants to merge 3 commits into
Conversation
arrjay
changed the title
corymhall
suggested changes
May 24, 2023
corymhall
left a comment
corymhall
left a comment
Contributor
There was a problem hiding this comment.
I also forgot to mention tests. Can you add a test to assert that these settings take effect?
|
+1 for this feature. |
Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>
kaizencc
suggested changes
Dec 24, 2024
kaizencc
left a comment
kaizencc
left a comment
Contributor
There was a problem hiding this comment.
To get this merged it needs the following:
- README update
- unit tests
- merge conflicts addressed
Please ping me if you need another review. Since this PR has been open for so long I would be happy if anyone from the community decided to take this one across the finish line. Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #116
the current implementation of this provides some known properties that are ok to pass along, rather than everything except the
synthesizerproperty.