Basis chisq - test #4

cdcapano · 2021-02-16T09:15:20Z

Not meant to be merged; just seeing differences.

pep8speaks · 2021-02-16T09:15:26Z

Hello @cdcapano! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pycbc/events/events.py:

Line 28:11: E401 multiple imports on one line
Line 38:1: E302 expected 2 blank lines, found 1
Line 44:1: E302 expected 2 blank lines, found 1
Line 51:1: E265 block comment should start with '# '
Line 52:1: E302 expected 2 blank lines, found 1
Line 58:1: E302 expected 2 blank lines, found 1
Line 64:1: E302 expected 2 blank lines, found 1
Line 68:1: E302 expected 2 blank lines, found 1
Line 79:41: E261 at least two spaces before inline comment
Line 89:1: E302 expected 2 blank lines, found 1
Line 93:80: E501 line too long (82 > 79 characters)
Line 98:80: E501 line too long (81 > 79 characters)
Line 135:22: E261 at least two spaces before inline comment
Line 137:28: E261 at least two spaces before inline comment
Line 155:80: E501 line too long (81 > 79 characters)
Line 156:18: E127 continuation line over-indented for visual indent
Line 159:1: E302 expected 2 blank lines, found 1
Line 181:1: E302 expected 2 blank lines, found 1
Line 191:21: E201 whitespace after '('
Line 191:59: E202 whitespace before ')'
Line 199:1: E302 expected 2 blank lines, found 1
Line 215:1: E302 expected 2 blank lines, found 1
Line 229:1: E302 expected 2 blank lines, found 1
Line 234:29: E201 whitespace after '['
Line 234:50: E202 whitespace before ']'
Line 235:35: E211 whitespace before '('
Line 236:37: E201 whitespace after '('
Line 236:55: E202 whitespace before ')'
Line 261:80: E501 line too long (107 > 79 characters)
Line 270:80: E501 line too long (98 > 79 characters)
Line 272:59: E502 the backslash is redundant between brackets
Line 273:13: E128 continuation line under-indented for visual indent
Line 332:80: E501 line too long (89 > 79 characters)
Line 333:16: E221 multiple spaces before operator
Line 341:54: E271 multiple spaces after keyword
Line 341:80: E501 line too long (82 > 79 characters)
Line 431:80: E501 line too long (82 > 79 characters)
Line 449:80: E501 line too long (109 > 79 characters)
Line 452:80: E501 line too long (123 > 79 characters)
Line 454:80: E501 line too long (125 > 79 characters)
Line 463:80: E501 line too long (113 > 79 characters)
Line 466:80: E501 line too long (93 > 79 characters)
Line 467:80: E501 line too long (94 > 79 characters)
Line 504:80: E501 line too long (104 > 79 characters)
Line 505:80: E501 line too long (91 > 79 characters)
Line 510:80: E501 line too long (98 > 79 characters)
Line 511:80: E501 line too long (85 > 79 characters)
Line 515:80: E501 line too long (88 > 79 characters)
Line 532:59: E231 missing whitespace after ','
Line 532:63: E231 missing whitespace after ','
Line 532:67: E225 missing whitespace around operator
Line 532:80: E501 line too long (86 > 79 characters)
Line 535:52: E231 missing whitespace after ','
Line 535:58: E225 missing whitespace around operator
Line 542:80: E501 line too long (86 > 79 characters)
Line 544:29: E127 continuation line over-indented for visual indent
Line 546:29: E127 continuation line over-indented for visual indent
Line 548:1: E302 expected 2 blank lines, found 1
Line 564:29: E201 whitespace after '['
Line 564:69: E202 whitespace before ']'
Line 565:35: E211 whitespace before '('
Line 566:37: E201 whitespace after '('
Line 566:55: E202 whitespace before ')'
Line 589:43: E128 continuation line under-indented for visual indent
Line 604:52: E127 continuation line over-indented for visual indent
Line 614:70: E221 multiple spaces before operator
Line 615:15: E127 continuation line over-indented for visual indent
Line 616:70: E221 multiple spaces before operator
Line 617:15: E127 continuation line over-indented for visual indent
Line 618:78: E502 the backslash is redundant between brackets
Line 662:61: E502 the backslash is redundant between brackets
Line 668:65: E502 the backslash is redundant between brackets
Line 669:21: E128 continuation line under-indented for visual indent
Line 685:25: E127 continuation line over-indented for visual indent
Line 686:25: E127 continuation line over-indented for visual indent
Line 689:80: E501 line too long (82 > 79 characters)
Line 689:82: E502 the backslash is redundant between brackets
Line 690:29: E128 continuation line under-indented for visual indent
Line 692:80: E501 line too long (84 > 79 characters)
Line 692:84: E502 the backslash is redundant between brackets
Line 693:29: E128 continuation line under-indented for visual indent
Line 696:80: E501 line too long (81 > 79 characters)
Line 697:80: E501 line too long (81 > 79 characters)
Line 702:80: E501 line too long (80 > 79 characters)
Line 702:80: E502 the backslash is redundant between brackets
Line 703:29: E128 continuation line under-indented for visual indent
Line 706:77: E502 the backslash is redundant between brackets
Line 707:25: E128 continuation line under-indented for visual indent
Line 708:74: E502 the backslash is redundant between brackets
Line 709:25: E128 continuation line under-indented for visual indent
Line 715:17: E265 block comment should start with '# '
Line 717:17: E265 block comment should start with '# '
Line 732:55: E502 the backslash is redundant between brackets
Line 736:55: E502 the backslash is redundant between brackets
Line 737:56: E502 the backslash is redundant between brackets
Line 739:74: E502 the backslash is redundant between brackets
Line 742:53: E502 the backslash is redundant between brackets
Line 746:80: E501 line too long (80 > 79 characters)
Line 746:80: E502 the backslash is redundant between brackets
Line 747:25: E128 continuation line under-indented for visual indent
Line 748:70: E502 the backslash is redundant between brackets
Line 749:25: E128 continuation line under-indented for visual indent
Line 753:80: E501 line too long (92 > 79 characters)
Line 761:80: E501 line too long (80 > 79 characters)
Line 768:67: E502 the backslash is redundant between brackets
Line 771:33: E127 continuation line over-indented for visual indent
Line 771:80: E501 line too long (83 > 79 characters)
Line 773:33: E127 continuation line over-indented for visual indent
Line 773:80: E501 line too long (83 > 79 characters)
Line 775:1: E305 expected 2 blank lines after class or function definition, found 1

In the file pycbc/inference/models/gaussian_noise.py:

Line 573:80: E501 line too long (82 > 79 characters)

In the file pycbc/io/hdf.py:

Line 707:13: E128 continuation line under-indented for visual indent

In the file pycbc/strain/strain.py:

Line 648:29: E128 continuation line under-indented for visual indent

In the file pycbc/vetoes/basischisq.py:

Line 64:44: E741 ambiguous variable name 'l'
Line 69:15: E231 missing whitespace after ','
Line 69:18: E231 missing whitespace after ','
Line 70:27: E231 missing whitespace after ','
Line 73:31: E231 missing whitespace after ','
Line 74:27: E231 missing whitespace after ','
Line 78:24: E231 missing whitespace after ','
Line 129:11: E231 missing whitespace after ','
Line 148:17: E231 missing whitespace after ','
Line 191:11: E231 missing whitespace after ','
Line 195:13: E128 continuation line under-indented for visual indent
Line 196:13: E128 continuation line under-indented for visual indent
Line 298:17: E128 continuation line under-indented for visual indent
Line 329:73: W291 trailing whitespace
Line 379:56: W291 trailing whitespace
Line 398:29: E127 continuation line over-indented for visual indent
Line 421:13: E128 continuation line under-indented for visual indent
Line 431:15: E231 missing whitespace after ','
Line 452:29: E127 continuation line over-indented for visual indent
Line 453:29: E127 continuation line over-indented for visual indent
Line 461:13: E128 continuation line under-indented for visual indent
Line 462:1: W391 blank line at end of file

In the file pycbc/waveform/phenomhm.py:

Line 28:16: E231 missing whitespace after ','
Line 28:23: E231 missing whitespace after ','
Line 28:30: E231 missing whitespace after ','
Line 28:37: E231 missing whitespace after ','
Line 28:44: E231 missing whitespace after ','
Line 28:51: E231 missing whitespace after ','
Line 31:1: E302 expected 2 blank lines, found 1
Line 34:1: W293 blank line contains whitespace
Line 42:5: W605 invalid escape sequence '*'
Line 78:13: E741 ambiguous variable name 'l'
Line 78:14: E231 missing whitespace after ','
Line 93:9: E741 ambiguous variable name 'l'
Line 93:10: E231 missing whitespace after ','
Line 94:9: E741 ambiguous variable name 'l'

In the file pycbc/waveform/waveform.py:

Line 45:23: W291 trailing whitespace
Line 603:80: E501 line too long (85 > 79 characters)

In the file test/test_infmodel.py:

Line 38:1: E302 expected 2 blank lines, found 1
Line 40:9: E266 too many leading '#' for block comment
Line 48:1: W293 blank line contains whitespace
Line 56:36: W291 trailing whitespace
Line 57:51: W291 trailing whitespace
Line 62:77: W291 trailing whitespace
Line 67:31: E231 missing whitespace after ':'
Line 68:19: E128 continuation line under-indented for visual indent
Line 68:26: E231 missing whitespace after ':'
Line 69:19: E128 continuation line under-indented for visual indent
Line 69:28: E231 missing whitespace after ':'
Line 70:19: E128 continuation line under-indented for visual indent
Line 70:32: E231 missing whitespace after ':'
Line 71:19: E128 continuation line under-indented for visual indent
Line 71:33: E231 missing whitespace after ':'
Line 72:19: E128 continuation line under-indented for visual indent
Line 73:19: E128 continuation line under-indented for visual indent
Line 74:19: E128 continuation line under-indented for visual indent
Line 75:18: E124 closing bracket does not match visual indentation
Line 77:21: E128 continuation line under-indented for visual indent
Line 78:20: E124 closing bracket does not match visual indentation
Line 79:26: E231 missing whitespace after ':'
Line 79:35: E231 missing whitespace after ':'
Line 79:44: E231 missing whitespace after ':'
Line 86:9: E266 too many leading '#' for block comment
Line 88:30: E231 missing whitespace after ':'
Line 88:50: E231 missing whitespace after ':'
Line 91:47: W291 trailing whitespace
Line 104:34: E127 continuation line over-indented for visual indent
Line 105:34: E127 continuation line over-indented for visual indent
Line 105:38: E251 unexpected spaces around keyword / parameter equals
Line 105:40: E251 unexpected spaces around keyword / parameter equals
Line 106:34: E127 continuation line over-indented for visual indent
Line 106:47: E251 unexpected spaces around keyword / parameter equals
Line 106:49: E251 unexpected spaces around keyword / parameter equals
Line 107:34: E127 continuation line over-indented for visual indent
Line 107:39: E251 unexpected spaces around keyword / parameter equals
Line 107:41: E251 unexpected spaces around keyword / parameter equals
Line 108:34: E127 continuation line over-indented for visual indent
Line 108:49: E251 unexpected spaces around keyword / parameter equals
Line 108:51: E251 unexpected spaces around keyword / parameter equals
Line 108:60: E231 missing whitespace after ':'
Line 109:34: E127 continuation line over-indented for visual indent
Line 109:41: E251 unexpected spaces around keyword / parameter equals
Line 109:43: E251 unexpected spaces around keyword / parameter equals
Line 118:29: E251 unexpected spaces around keyword / parameter equals
Line 118:31: E251 unexpected spaces around keyword / parameter equals
Line 119:38: E251 unexpected spaces around keyword / parameter equals
Line 119:40: E251 unexpected spaces around keyword / parameter equals
Line 120:30: E251 unexpected spaces around keyword / parameter equals
Line 120:32: E251 unexpected spaces around keyword / parameter equals
Line 125:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated at 2021-03-15 10:19:39 UTC

* Fix missing bits from gwastro#3057 * Ian's suggestion * This is now unnecessary

* speed up field array access when using eval * fix * cc * fix

* add intended python requirement * update * Update setup.py

* Fix bug in final_spin_from_initial * spin floats Co-authored-by: Miriam Cabero <[email protected]>

* add inference model test * speed up relative model * cc

…el (gwastro#3652) * fixes for single template model * cc

* simple convenience plot method * add in case of complex data

Don't calculate lognl in loglikelihood

dethodav and others added 29 commits March 10, 2021 13:09

Propogate tags to minifollowup jobs (gwastro#3667)

6916603

Fix missing bits from gwastro#3057 (gwastro#3663)

5a80df7

* Fix missing bits from gwastro#3057 * Ian's suggestion * This is now unnecessary

speed up field array access when using eval (gwastro#3655)

152637c

* speed up field array access when using eval * fix * cc * fix

make it easier to load data and models (gwastro#3668)

03fd404

add intended python requirement (gwastro#3666)

1ccf96e

* add intended python requirement * update * Update setup.py

Fix bug in final_spin_from_initial (gwastro#3650)

5354d34

* Fix bug in final_spin_from_initial * spin floats Co-authored-by: Miriam Cabero <[email protected]>

Remove unnecessary execution bits from .py files (gwastro#3664)

1be2a9d

add option to make saving data optional (gwastro#3669)

87ecd4d

updates to relative model (gwastro#3649)

95d1876

* add inference model test * speed up relative model * cc

fix polarization marginalization normalization in single template mod…

836e93d

…el (gwastro#3652) * fixes for single template model * cc

fix loop on failed attribute (gwastro#3670)

138ee11

simple convenience plot method (gwastro#3672)

9ba3ad1

* simple convenience plot method * add in case of complex data

Fix a couple more LISA problems (gwastro#3674)

6cd8c3f

add function to call phenomhm modes directly

bf5fef1

add inverse_psd function

a52216c

add ability to generate individual modes to FilterBank

f093f8a

add dict giving approximants that allow individual modes to be generated

55cd266

bug fix

1452296

add HM chisq

48e1f41

add support for HM chisq to pycbc_inspiral

ee04b87

fix bugs

5eef757

more bug fixes

2c1e2a5

more bugs

0c6864f

various bug fixes

40278c9

write the hm chisq out to file

f65bcda

prune modes that are 0; expect list of snrs rather than time series

1e9b7d0

pass normalized SNR

437fe37

add combined chisq

fa3ee52

add plotting support

17a6108

Collin Capano added 5 commits March 15, 2021 11:16

fix default in errorbar

07dc180

fix time shifting

b5de53e

raise error if kmin and kmax are the same

a9367e2

deal with negative durations

6eab6cf

whiten template when computing coefficients

2a01fb6

cdcapano force-pushed the basis_chisq branch from 0b37bf3 to 2a01fb6 Compare March 15, 2021 10:19

cdcapano pushed a commit that referenced this pull request Mar 18, 2021

Merge pull request #4 from cdcapano/pycbcGatedGaussian

767947c

Don't calculate lognl in loglikelihood

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Basis chisq - test #4

Basis chisq - test #4

Uh oh!

cdcapano commented Feb 16, 2021

Uh oh!

pep8speaks commented Feb 16, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Basis chisq - test #4

Are you sure you want to change the base?

Basis chisq - test #4

Uh oh!

Conversation

cdcapano commented Feb 16, 2021

Uh oh!

pep8speaks commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2021-03-15 10:19:39 UTC

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pep8speaks commented Feb 16, 2021 •

edited

Loading