[PLUGIN-1867] Error management changes for CSV parser #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
235
to
237
| String error = String.format("Number of values are not as per output schema. " + | ||
| "Expected %d values, but found only %d values", fields.size(), record.size()); | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), |
There was a problem hiding this comment.
It will be great if we can log the whole record here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error Management for CSVParser transform plugin exceptions
https://cdap.atlassian.net/browse/PLUGIN-1867
Code change
Modified CSVParser.java
Tests
Test Case - tested with valid and invalid scenarios
1. Success
2. Missing CSV values
3. Empty CSV values