Improve test coverage and Node environment

.github/workflows/ci.yml

@@ -25,14 +25,14 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: Install pnpm
-      uses: pnpm/action-setup@v2
+      uses: pnpm/action-setup@v4
       with:
-        version: 8
+        version: 10
 
     - name: Use Node.js
       uses: actions/setup-node@v4
       with:
-        node-version: '20'
+        node-version: '24'
         cache: 'pnpm'
 
     - name: Install dependencies

.nvmrc

@@ -0,0 +1 @@
+v24

package.json

@@ -3,6 +3,9 @@
   "version": "1.0.0",
   "description": "[**🏆 Live Demo →**](https://ccombe.github.io/emom-timer/)",
   "main": "src/js/app.js",
+  "engines": {
+    "node": ">=24.0.0"
+  },
   "scripts": {
     "dev": "vite",
     "build": "tsc && vite build",
@@ -22,13 +25,14 @@
   },
   "homepage": "https://github.com/ccombe/emom-timer#readme",
   "devDependencies": {
-    "@types/node": "^20.19.33",
+    "@types/node": "^20.19.35",
     "@vitest/coverage-v8": "^4.0.18",
     "fake-indexeddb": "^6.2.5",
     "idb": "^8.0.3",
     "jsdom": "^27.4.0",
     "typescript": "^5.9.3",
     "vite": "^7.3.1",
     "vitest": "^4.0.18"
-  }
+  },
+  "packageManager": "pnpm@10.30.2"
 }

pnpm-workspace.yaml

@@ -0,0 +1,2 @@
+overrides:
+  rollup@>=4.0.0 <4.59.0: '>=4.59.0'

src/ts/google-fit.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { GoogleFitService } from './google-fit.ts';
 
 // Mock Fetch
@@ -30,10 +30,81 @@ describe('GoogleFitService', () => {
     beforeEach(() => {
         vi.clearAllMocks();
         localStorage.clear();
+        // Mock Date.now() for consistent testing
+        vi.useFakeTimers();
+        vi.setSystemTime(new Date('2024-01-01T12:00:00Z'));
         service = new GoogleFitService();
         service.accessToken = 'mock-token'; // Simulate connected
     });
 
+    afterEach(() => {
+        vi.useRealTimers();
+    });
+
+    describe('constructor and token expiry', () => {
+        it('clears expired token on initialization', () => {
+            localStorage.setItem('google_fit_token', 'old-token');
+            localStorage.setItem('google_fit_token_expiry', (Date.now() - 1000).toString());
+
+            const logSpy = vi.spyOn(console, 'log').mockImplementation(() => { });
+            const newService = new GoogleFitService();
+            expect(newService.accessToken).toBeNull();
+            expect(localStorage.getItem('google_fit_token')).toBeNull();
+            logSpy.mockRestore();
+        });
+
+        it('retains valid token on initialization', () => {
+            const future = Date.now() + 3600000;
+            localStorage.setItem('google_fit_token', 'valid-token');
+            localStorage.setItem('google_fit_token_expiry', future.toString());
+
+            const newService = new GoogleFitService();
+            expect(newService.accessToken).toBe('valid-token');
+        });
+    });
+
+    describe('initialize', () => {
+        it('does nothing if window.google is missing', () => {
+            const originalGoogle = window.google;
+            delete (window as any).google;
+            service.initialize();
+            expect(service.tokenClient).toBeNull();
+            window.google = originalGoogle;
+        });
+
+        it('initializes token client when window.google exists', () => {
+            const mockInitTokenClient = vi.fn().mockReturnValue({ requestAccessToken: vi.fn() });
+            (window as any).google = {
+                accounts: {
+                    oauth2: {
+                        initTokenClient: mockInitTokenClient
+                    }
+                }
+            };
+
+            service.initialize();
+            expect(mockInitTokenClient).toHaveBeenCalled();
+            expect(service.tokenClient).toBeDefined();
+        });
+    });
+
+    describe('connect', () => {
+        it('calls requestAccessToken if client exists', () => {
+            const requestMock = vi.fn();
+            service.tokenClient = { requestAccessToken: requestMock };
+            service.connect();
+            expect(requestMock).toHaveBeenCalled();
+        });
+
+        it('logs error if client does not exist', () => {
+            const spy = vi.spyOn(console, 'error').mockImplementation(() => { });
+            service.tokenClient = null;
+            service.connect();
+            expect(spy).toHaveBeenCalledWith("Google Identity Services not initialized.");
+            spy.mockRestore();
+        });
+    });
+
     describe('uploadSession', () => {
         it('uploads valid session data', async () => {
             const session = {
@@ -82,8 +153,14 @@ describe('GoogleFitService', () => {
                 json: async () => ({ error: "Bad request" })
             });
 
+            // Mock console.error to avoid noisy stderr in tests
+            const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => { });
+
             const result = await service.uploadSession({ duration: 60, interval: 60, activityType: 114 });
             expect(result).toBe(false);
+
+            expect(consoleSpy).toHaveBeenCalled();
+            consoleSpy.mockRestore();
         });
     });
 
@@ -118,6 +195,15 @@ describe('GoogleFitService', () => {
             expect(dates).toEqual([]);
         });
 
+        it('handles fetch exceptions gracefully', async () => {
+            (fetch as any).mockRejectedValueOnce(new Error('Network failure'));
+            const spy = vi.spyOn(console, 'error').mockImplementation(() => { });
+            const dates = await service.fetchWorkoutHistory();
+            expect(dates).toEqual([]);
+            expect(spy).toHaveBeenCalled();
+            spy.mockRestore();
+        });
+
         it('handles malformed/empty buckets gracefully', async () => {
             const mockResponse = {
                 bucket: [

src/ts/logic.test.ts

@@ -72,6 +72,10 @@ describe('Core Logic', () => {
         it('handles finished state', () => {
             expect(getCurrentRound({ elapsed: 300, intervalDuration: intervalSecs, totalDuration })).toEqual({ current: 5, total: 5 });
         });
+
+        it('handles very large elapsed time gracefully', () => {
+            expect(getCurrentRound({ elapsed: 1000, intervalDuration: intervalSecs, totalDuration })).toEqual({ current: 5, total: 5 });
+        });
     });
 
     describe('isFinished', () => {
@@ -116,6 +120,22 @@ describe('Core Logic', () => {
             const result = getCountdownBeep(context);
             expect(result.shouldBeep).toBe(false);
         });
+
+        it('should beep for different beep codes when lastBeepId is different', () => {
+            // Test 3 seconds remaining (57s)
+            const res1 = getCountdownBeep({ elapsed: 57, intervalDuration: 60, lastBeepId: '0-2' });
+            expect(res1.shouldBeep).toBe(true);
+            if (res1.shouldBeep) {
+                expect(res1.frequency).toBe(440);
+            }
+
+            // Test 2 seconds remaining (58s)
+            const res2 = getCountdownBeep({ elapsed: 58, intervalDuration: 60, lastBeepId: '0-3' });
+            expect(res2.shouldBeep).toBe(true);
+            if (res2.shouldBeep) {
+                expect(res2.frequency).toBe(554);
+            }
+        });
     });
 
     describe('normalizeDate', () => {

src/ts/storage.test.ts

@@ -1,14 +1,31 @@
-import { describe, it, expect, beforeEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { StorageService } from './storage.ts';
 import 'fake-indexeddb/auto';
 
 describe('StorageService', () => {
     let storage: StorageService;
 
-    beforeEach(() => {
+    beforeEach(async () => {
+        // Clear IndexedDB to ensure test isolation
+        const DB_NAME = 'emom-timer-db';
+        const request = indexedDB.deleteDatabase(DB_NAME);
+        await new Promise((resolve, reject) => {
+            request.onsuccess = resolve;
+            request.onerror = reject;
+            request.onblocked = () => {
+                // If blocked, we might have a leak, but for tests we try to proceed
+                resolve(null);
+            };
+        });
         storage = new StorageService();
     });
 
+    afterEach(async () => {
+        if (storage) {
+            await storage.close();
+        }
+    });
+
     it('saves and retrieves session', async () => {
         const session = {
             duration: 300,
@@ -64,4 +81,23 @@ describe('StorageService', () => {
         const streak = await storage.getStreak();
         expect(streak).toBe(2);
     });
+
+    it('saves and loads settings', async () => {
+        const settings = {
+            intervalCount: 8,
+            intervalSecs: 45,
+            activityType: 114,
+            includeLocation: true,
+            setupComplete: true
+        };
+
+        await storage.saveSettings(settings);
+        const loaded = await storage.loadSettings();
+        expect(loaded).toEqual(settings);
+    });
+
+    it('returns undefined for non-existent settings', async () => {
+        const settings = await storage.loadSettings();
+        expect(settings).toBeUndefined();
+    });
 });

src/ts/storage.ts

@@ -75,4 +75,9 @@ export class StorageService {
         const dates = sessions.map(s => s.date);
         return calculateStreak(dates);
     }
+
+    async close(): Promise<void> {
+        const db = await this.dbPromise;
+        db.close();
+    }
 }