Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing facebook pop up error #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

IdoBn
Copy link

@IdoBn IdoBn commented May 16, 2014

When you would go to sign up facebook would give you an error.
screen shot 2014-05-16 at 10 07 22 pm

@theptrk
Copy link

theptrk commented May 26, 2014

I cant recreate this issue but you can presumably set the size of the window before it opens by adding additional arguments to window.open.

Here is a relevant answer
http://stackoverflow.com/questions/5653858/fb-share-in-new-window

@IdoBn
Copy link
Author

IdoBn commented May 26, 2014

I was able to fix the issue by removing

 "display=popup"

from

 window.open(FB_LOGIN_URL + '?client_id=' + fbAppId + '&redirect_uri=' + oauthRedirectURL + '&response_type=token&display=popup&scope=' + fbScope, '_blank', 'location=no');

@theptrk
Copy link

theptrk commented May 26, 2014

Awesome. Its in openfb-angular.js on line 87 if anyone else runs into the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants