Make testing and installing rulesets more reliable

[smortex]

If a pattern database is failing, it is not installed, but on subsequent run of Puppet the pattern database is not tested again and the configuration converge to a state where the expected pattern database is not installed.

Rework the pattern database testing and installation so that a failing pattern database fail on each subsequent run of Puppet, so that errors can be spotted more easily.

Fixes #42

[faxm0dem]

I have to test this but it looks good, thanks !
I tested it and it works indeed using our setup.
Then it got me thinking : wouldn't it be great if /etc/syslog-ng/patterndb/ was also up-to-date, with patterns that actually validated ? I think it's overkill to pdb test all the files individually and would slow things down. But we could keep the old valid /etc/syslog-ng/patterndb/ files if the pdb test <merged file> fails, what do you think ?

[smortex]

Then it got me thinking : wouldn't it be great if /etc/syslog-ng/patterndb/ was also up-to-date, with patterns that actually validated ? I think it's overkill to pdb test all the files individually and would slow things down. But we could keep the old valid /etc/syslog-ng/patterndb/ files if the pdb test <merged file> fails, what do you think ?

I have to admit that these files in /etc/syslog-ng/patterndb/ confused me when I was starting using the module. Maybe having the fragments go to /var/cache/... and the merged files to /var/lib/... would have helped me not trying to use the former when I wanted the latter. Now, I know how it works, so I don't really care 🤷

[faxm0dem]

I'm sorry I won't have time to test this.
I trust you if it's been working fine by you!