Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration is deceptive on pdbtool(1) error #42

Closed
smortex opened this issue Aug 9, 2023 · 0 comments · Fixed by #44
Closed

Configuration is deceptive on pdbtool(1) error #42

smortex opened this issue Aug 9, 2023 · 0 comments · Fixed by #44

Comments

@smortex
Copy link
Collaborator

smortex commented Aug 9, 2023

When patterndb rules are changed:

  1. the files are changed on disk in /etc/syslog-ng/patterndb.d;
  2. the files are merged into a temporary directory;
  3. pdbtool(1) is run to validate the merged rules and on success;
  4. the merged rules are installed in /var/lib/syslog-ng/patterndb.

If at step 3 the command fail, the merged rules are not installed, and the user is reported by puppet.

But on the next run, the files in /etc/syslog-ng/patterndb.d match what is expected, no merge is done, no validation is tried, no installation is done. So we end-up with a catalog that apply successfully without changes, but we are still using the previous patterndb configuration.

When adding broken rules, the process should fail at each puppet run until fixed.
smortex added a commit that referenced this issue Aug 10, 2023
@smortex
Make testing and installing more reliable
169913b 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration to a state where the expected pattern database is not
installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
@smortex smortex mentioned this issue Aug 10, 2023
Merged
smortex added a commit that referenced this issue Aug 10, 2023
@smortex
Make testing and installing more reliable
6bb7e55 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 10, 2023
@smortex
Make testing and installing more reliable
232113c 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 10, 2023
@smortex
Make testing and installing more reliable
a4f7d28 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 10, 2023
@smortex
Make testing and installing more reliable
cb82e74 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 10, 2023
@smortex
Make testing and installing more reliable
fb72a09 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 11, 2023
@smortex
Make testing and installing more reliable
f64ea9c 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 11, 2023
@smortex
Make testing and installing more reliable
2bed001 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Aug 31, 2023
@smortex
Make testing and installing more reliable
ddf1468 
If a pattern database is failing, it is not installed, but on subsequent
run of Puppet the pattern database is not tested again and the
configuration converge to a state where the expected pattern database is
not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Jan 23, 2025
@smortex
Make testing and installing more reliable
3c9a2d1 
If a pattern database test is failing, it is not installed, but on
subsequent run of Puppet the non-working pattern database is considered
unchanged by puppet so not tested again and the configuration converge
to a state where the updated pattern database is not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Jan 23, 2025
@smortex
Make testing and installing more reliable
8de0a2b 
If a pattern database test is failing, it is not installed, but on
subsequent run of Puppet the non-working pattern database is considered
unchanged by puppet so not tested again and the configuration converge
to a state where the updated pattern database is not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Jan 23, 2025
@smortex
Make testing and installing more reliable
50a00ad 
If a pattern database test is failing, it is not installed, but on
subsequent run of Puppet the non-working pattern database is considered
unchanged by puppet so not tested again and the configuration converge
to a state where the updated pattern database is not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Jan 23, 2025
@smortex
Make testing and installing more reliable
0f1278b 
If a pattern database test is failing, it is not installed, but on
subsequent run of Puppet the non-working pattern database is considered
unchanged by puppet so not tested again and the configuration converge
to a state where the updated pattern database is not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
smortex added a commit that referenced this issue Jan 23, 2025
@smortex
Make testing and installing more reliable
18d408e 
If a pattern database test is failing, it is not installed, but on
subsequent run of Puppet the non-working pattern database is considered
unchanged by puppet so not tested again and the configuration converge
to a state where the updated pattern database is not installed.

Rework the pattern database testing and installation so that a failling
pattern database fail on each subsequent run of Puppet, so that errors
can be spotted more easily.

Fixes #42
@smortex smortex closed this as completed in ab906fe Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make testing and installing rulesets more reliable ccin2p3/puppet-patterndb
1 participant
@smortex