Skip to content

Settings tabs/buttons element UX #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Settings tabs/buttons element UX #2867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7c55d8
Update style.css
duanemoody Dec 1, 2020
07e96af
Update Settings.html
duanemoody Dec 1, 2020
e8c4f85
Update style.css
duanemoody Dec 1, 2020
bfbfa24
Update style.css
duanemoody Dec 1, 2020
1e2d945
Update style.css
duanemoody Dec 1, 2020
bae53e1
Update Settings.coffee
duanemoody Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/General/Settings.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Settings =
textContent: section.title
href: 'javascript:;'
$.on link, 'click', Settings.openSection.bind section
links.push link, $.tn ' | '
links.push link
sectionToOpen = link if section.title is openSection
links.pop()
$.add $('.sections-list', dialog), links
Expand Down
6 changes: 3 additions & 3 deletions src/General/Settings/Settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<div class="sections-list"></div>
<p class="imp-exp-result warning"></p>
<div class="credits">
<a class="export">Export</a>&nbsp|&nbsp
<a class="import">Import</a>&nbsp|&nbsp
<a class="reset">Reset Settings</a>&nbsp|&nbsp
<button class="impexres"><a class="export">Export</a></button>
<button class="impexres"><a class="import">Import</a></button>
<button class="impexres"><a class="reset">Reset Settings</a></button>
<input type="file" hidden>
<a href="<%= meta.page %>" target="_blank"><%= meta.name %></a>&nbsp|&nbsp
<a href="<%= meta.changelog %>" target="_blank">${g.VERSION}</a>&nbsp|&nbsp
Expand Down
19 changes: 19 additions & 0 deletions src/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,13 +555,32 @@ audio.controls-added {
.sections-list {
-webkit-flex: 1;
flex: 1;
border-bottom: 1px solid #ccc;
}
.export, .import, .reset {
cursor: pointer;
text-decoration: none !important;
}
#fourchanx-settings > button.impexres {
margin-right:.5em;
}
#fourchanx-settings > button.impexres > a, #fourchanx-settings > button.impexres > a:visited {
color:initial;
}
div.sections-list a {
display: inline-block;
border: 1px solid #ccc;
border-top-left-radius: 6px;
border-top-right-radius: 6px;
border-bottom: none;
padding: 0 3px;
margin-right: -1px;
text-decoration: none !important;
}
.tab-selected {
font-weight: 700;
color:#000 !important;
background-color:#ccc;
}
.section-sauce ul,
.section-advanced ul {
Expand Down