Skip to content

Commit

Permalink
fix: a11y improvements to libraryh3lp
Browse files Browse the repository at this point in the history
onclick event on non-interactive tag (span) isn't accessible for keyboard users
so use button for the X close on chat bubbles
  • Loading branch information
phette23 committed Nov 26, 2024
1 parent ee2a04e commit d498ffc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion libraryh3lp/inst-offline.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
font-size: 1.2em;
}
}
.libraryh3lp a span.close-lh3-chat-tab {
.libraryh3lp a .close-lh3-chat-tab {
border: 1px solid #666;
background: #fff;
color: #000;
Expand Down
2 changes: 1 addition & 1 deletion libraryh3lp/inst-online.html
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Questions? Ask us!
<span class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;"></span>
<button class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;"></button>
2 changes: 1 addition & 1 deletion libraryh3lp/libs-offline.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
font-size: 1.2em;
}
}
.libraryh3lp a span.close-lh3-chat-tab {
.libraryh3lp a .close-lh3-chat-tab {
border: 1px solid #666;
background: #fff;
color: #000;
Expand Down
2 changes: 1 addition & 1 deletion libraryh3lp/libs-online.html
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Questions? Chat with a Librarian!
<span class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;"></span>
<button class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;"></button>

0 comments on commit d498ffc

Please sign in to comment.