-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: a11y improvements to libraryh3lp
onclick event on non-interactive tag (span) isn't accessible for keyboard users so use button for the X close on chat bubbles
- Loading branch information
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Questions? Ask us! | ||
<span class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;">☓</span> | ||
<button class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;">☓</button> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Questions? Chat with a Librarian! | ||
<span class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;">☓</span> | ||
<button class="close-lh3-chat-tab" onclick="closeLH3ChatTab(event); return true;">☓</button> |