Feat#19 회원,학교 목록 가져오기 by hanachooi · Pull Request #20 · cbnu-sequence/anonymous-backend

hanachooi · 2023-10-05T13:16:14Z

No description provided.

ckyeon · 2023-10-05T13:48:13Z

src/main/java/com/sequence/anonymous/user/presentation/CollegeController.java

+
+@RequiredArgsConstructor
+@RestController
+@RequestMapping("/api/colleges")


스펙상 rest api 앞에는 /api가 붙지 않습니다~

ckyeon · 2023-10-05T13:49:05Z

src/main/java/com/sequence/anonymous/user/presentation/CollegeController.java

+
+    private final CollegeService collegeService;
+
+    @GetMapping("/")


rest api 규칙 중 마지막에 /가 붙지 않는 규칙이 있습니다.

ckyeon · 2023-10-05T13:50:02Z

src/main/java/com/sequence/anonymous/user/presentation/CollegeController.java

+    public ResponseEntity<List<College>> findAll(){
+
+        List<College> college = collegeService.printAll();
+        return ResponseEntity.status(HttpStatus.CREATED).body((List<College>) college);


HttpStatus.CREATED 보다 HttpStatus.OK 가 더 적합한 것 같습니다~

ckyeon · 2023-10-05T13:50:35Z

src/main/java/com/sequence/anonymous/user/presentation/TagController.java

  private final TagService tagService;
+
+  @GetMapping("/")
+  public ResponseEntity<List<Tag>>findAll(){


커밋 전 idea의 포메팅 기능 이용을 부탁드립니다!

ckyeon · 2023-10-05T13:50:44Z

src/main/java/com/sequence/anonymous/user/presentation/TagController.java

+  public ResponseEntity<List<Tag>>findAll(){
+
+    List<Tag> tag = tagService.printAll();
+    return ResponseEntity.status(HttpStatus.CREATED).body((List<Tag>) tag);


HttpStatus.CREATED 보다 HttpStatus.OK 가 더 적합한 것 같습니다~

(List)를 통해 형변환이 이루어지고 있는데,
불필요한 코드 같습니다!

ckyeon · 2023-10-05T13:52:06Z

src/main/java/com/sequence/anonymous/user/application/TagService.java

-}
+
+
+  public List<Tag> printAll(){


함수의 기능상 printAll()보다 findAll()이 더 적합한 것 같습니다!

ckyeon · 2023-10-05T13:52:13Z

src/main/java/com/sequence/anonymous/user/application/CollegeService.java

+    private CollegeRepository collegeRepository;
+
+
+    public List<College> printAll(){


함수의 기능상 printAll()보다 findAll()이 더 적합한 것 같습니다!

ckyeon · 2023-10-05T13:52:47Z

src/main/java/com/sequence/anonymous/user/domain/College.java

+    @GeneratedValue(strategy = GenerationType.IDENTITY)
+    private Long id;
+
+    @Column(unique = true, insertable = false, updatable = false, length = 10)


컬럼 조건을 상세하게 지정해주셨네요 👍👍

ckyeon · 2023-11-18T13:07:46Z

src/main/java/com/sequence/anonymous/config/SecurityConfig.java


    http.authorizeHttpRequests()
-      .anyRequest().authenticated();
+      .anyRequest().permitAll();


insomnia 사용하실 때만 임시로만 부탁드리겠습니다

ckyeon · 2023-11-18T13:08:38Z

src/main/java/com/sequence/anonymous/user/application/CollegeService.java

+import java.util.List;
+@RequiredArgsConstructor


Ctrl + Alt + L 단축키 사용하셔서 포매팅 부탁드립니다~

ckyeon · 2023-11-18T13:09:24Z

src/main/java/com/sequence/anonymous/user/application/CollegeService.java

+    public List<College> findAll() {
+        return collegeRepository.findAll();
+    }


Controller <-> Service간에 데이터를 전달할 때는 entity 보다는 dto를 사용하는 것이 좋습니다~

ckyeon · 2023-11-18T13:11:03Z

src/main/java/com/sequence/anonymous/user/application/TagService.java

+  public List<Tag> findAll(){
+    return tagRepository.findAll();  }
+}


Controller <-> Service간에 데이터를 전달할 때는 entity 보다는 dto를 사용하는 것이 좋습니다~

ckyeon · 2023-11-18T13:11:35Z

src/main/java/com/sequence/anonymous/user/domain/College.java

+
+@Getter
+@Entity
+@Table(name = "College")


보통 데이터베이스 테이블 이름, 컬럼과 같은 곳에는 소문자만을 사용하는 것이 기본 컨벤션입니다.

ckyeon · 2023-11-18T13:15:35Z

src/main/java/com/sequence/anonymous/user/domain/Department.java

+    @ManyToMany
+    @JoinTable(schema = "College")
+    private List<College> users = new ArrayList<>();


collages가 조금 더 적합한 네이밍일 것 같습니다~

ckyeon · 2023-11-18T13:16:03Z

src/main/java/com/sequence/anonymous/user/domain/dto/CollegeResponse.java

+@Getter
+public class CollegeResponse {
+
+    private final Long id;
+    private final String collegeName;
+
+
+    public CollegeResponse(College college){
+
+        this.id = college.getId();
+        this.collegeName = college.getName();
+
+    }
+
+
+}


요즘 dto를 만들 때는 record를 사용하시면 편리합니다~

ckyeon · 2023-11-18T13:16:10Z

src/main/java/com/sequence/anonymous/user/domain/dto/TagResponse.java

+@Getter
+public class TagResponse {
+
+    private final Long id;
+    private final String user;
+
+
+    public TagResponse(Tag tag){
+        this.id = tag.getId();
+        this.user = tag.getName();
+    }
+
+
+}


요즘 dto를 만들 때는 record를 사용하시면 편리합니다~

ckyeon · 2023-11-18T13:18:09Z

src/main/java/com/sequence/anonymous/user/presentation/CollegeController.java

+    public ResponseEntity<List<College>> findAll(){
+
+        List<College> college = collegeService.findAll();
+        return ResponseEntity.status(HttpStatus.OK).body((List<College>) college);


ResponseEntity.ok(body)를 사용하시면 조금 더 간결하고 편리하게 사용하실 수 있을 것 같습니다~

ckyeon · 2023-11-18T13:18:18Z

src/main/java/com/sequence/anonymous/user/presentation/TagController.java


-  private final TagService tagService;
+        List<Tag> tag = tagService.findAll();
+        return ResponseEntity.status(HttpStatus.OK).body(tag);


ResponseEntity.ok(body)를 사용하시면 조금 더 간결하고 편리하게 사용하실 수 있을 것 같습니다~

hanachooi added 2 commits October 5, 2023 21:16

성격 태그 가져오기

89c0670

성격 태그 가져오기 + 학교 목록 가져오기

59cfced

ckyeon requested changes Oct 5, 2023

View reviewed changes

이전 코드 최종

64ddcb2

ckyeon requested changes Nov 18, 2023

View reviewed changes


		private final CollegeService collegeService;

		@GetMapping("/")

		private CollegeRepository collegeRepository;


		public List<College> printAll(){

		import java.util.List;
		@RequiredArgsConstructor

Conversation

hanachooi commented Oct 5, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants