Conversation
Open
ckyeon
requested changes
Oct 5, 2023
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/presentation/FriendController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/presentation/dto/FriendResponse.java
Outdated
Show resolved
Hide resolved
ckyeon
requested changes
Oct 8, 2023
src/main/java/com/sequence/anonymous/friend/presentation/FriendController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/presentation/FriendController.java
Outdated
Show resolved
Hide resolved
…사용하도록 수정. userId를 getter를 통해 얻도록 수정
ckyeon
requested changes
Oct 9, 2023
Member
ckyeon
left a comment
ckyeon
left a comment
There was a problem hiding this comment.
각 객체들의 벨리데이션도 잘해주시고 전체적인 완성도가 👍입니다~
화이팅!!
src/main/java/com/sequence/anonymous/friend/application/FriendService.java
Show resolved
Hide resolved
src/main/java/com/sequence/anonymous/friend/presentation/FriendController.java
Outdated
Show resolved
Hide resolved
ckyeon
approved these changes
Oct 26, 2023
Member
ckyeon
left a comment
ckyeon
left a comment
There was a problem hiding this comment.
전체적으로 잘 짜주셨네요~~ 👍👍
그런데 다음부터 feat(entities): User 엔티티를 지연로딩 하도록 수정 커밋을 좀 더 명확하게
feat(Friend): change FetchType EAGER to LAZY
feat(Invite): change FetchType EAGER to LAZY
위와 같이 분할해주시면 더 좋을 것 같습니다!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.