Created dim_classes.sql and dim_classes.yml. Updates stg_classes.sql.#34
Conversation
…alues testing. Also updated stg_classes.sql as this was previously missing capacity.
| @@ -11,6 +11,8 @@ staged as ( | |||
|
|
|||
| cast(category_id as integer) as category_id, | |||
There was a problem hiding this comment.
Weren't we going to keep category ID as not an integer?
There was a problem hiding this comment.
We did, but then it ended up clashing with a different model that someone else wrote and was throwing up an error. We decided to leave it as an integer for now.
There was a problem hiding this comment.
Yes so in the stg_class_categgories, I believe @rosie-taylor you might have cast the parent and child ids as intergers and therfore the category id might have needed to be cast as and integer or inferred explicity.
| - not_null | ||
| - accepted_values: | ||
| arguments: | ||
| values: ['Fitness', 'Combat', 'Wellness', 'Strength', 'Muay Thai', 'Boxing', 'Yoga', 'Pilates', 'Hiit', 'Mobility'] |
There was a problem hiding this comment.
The word "values" should be indented here to make sure the structure is valid, matching the class_name section above.
| - not_null | ||
| - accepted_values: | ||
| arguments: | ||
| values: ['Fitness', 'Combat', 'Wellness', 'Strength'] |
There was a problem hiding this comment.
"values" to be indented here too.
| - not_null | ||
| - accepted_values: | ||
| arguments: | ||
| values: ['Bow', 'Stratford', 'Canary Wharf', 'Hackney'] |
There was a problem hiding this comment.
"values" to be indented.
| - accepted_values: | ||
| arguments: | ||
| quote: false | ||
| values: [15, 30, 45, 60, 75, 90] |
There was a problem hiding this comment.
Values and quote should be indented under arguments.
4 participants
finalized dim_classes with formatted columns and full accepted values testing. Also updated stg_classes.sql as this was previously missing 'capacity'.