int-member-bookings#32
Open
sanaf26 wants to merge 2 commits into
Open
Conversation
harjeetkalsi
requested changes
Apr 9, 2026
Collaborator
harjeetkalsi
left a comment
harjeetkalsi
left a comment
There was a problem hiding this comment.
Looks good, but you need an int_member_booking.yml as you are missing any tests currently
Collaborator
Author
|
added tests |
|
|
||
| - name: first_name | ||
| description: "Member first name." | ||
|
|
Collaborator
There was a problem hiding this comment.
not null test needed
|
|
||
| - name: last_name | ||
| description: "Member last name." | ||
|
|
Collaborator
There was a problem hiding this comment.
not null tests needed
| from bookings | ||
| left join members | ||
| on bookings.member_id = members.member_id | ||
|
|
Collaborator
There was a problem hiding this comment.
you will need a unit test in the int_member_bookings.yml to test this logic
|
|
||
| - name: missing_email_flag | ||
| description: "True when the member email is missing or blank." | ||
|
|
Collaborator
There was a problem hiding this comment.
not null tests needed
|
|
||
| - name: date_of_birth | ||
| description: "Member date of birth." | ||
|
|
Collaborator
There was a problem hiding this comment.
not null tests needed
|
|
||
| - name: membership_status | ||
| description: "Standardised membership status from stg_members." | ||
|
|
Collaborator
There was a problem hiding this comment.
not null tests needed
|
|
||
| - name: join_date | ||
| description: "Date the member joined." | ||
|
|
Collaborator
There was a problem hiding this comment.
not null tests needed
| description: "Standardised membership status from stg_members." | ||
|
|
||
| - name: home_club | ||
| description: "Member home club." No newline at end of file |
Collaborator
There was a problem hiding this comment.
not null tests needed and maybe accepted values test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created int_member_bookings to join bookings and members at booking grain.
Ticket here - #21
What I changed
Joined bookings (source) to stg_members
Exposed member attributes alongside each booking: