Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds for Linux <4.14 #66

Closed

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented May 24, 2018

As a preparation for upstreaming the driver, this commit removes the
workarounds needed to use it with Linux <4.14, as such workarounds
probably won't be accepted upstream.

I'm not entirely sure if this PR should be merged right now or closer
before upstreaming, but at least here it is already.

As a preparation for upstreaming the driver, this commit removes the
workarounds needed to use it with Linux <4.14, as such workarounds
probably won't be accepted upstream.
@roadrunner2
Copy link
Contributor

The intent by all means was/is to remove the workarounds in the version submitted upstream. But I don't think we should be removing them here, since folks with older kernels may well be trying use this.

@Dunedan
Copy link
Contributor Author

Dunedan commented Jun 16, 2018

I believe this driver should get mainlined as soon as possible. While it's not perfect yet (and maybe it'll never be), it works flawlessly for day to day use. Not having it included upstream is a major hurdle for new users to get Linux running on the latest MacBooks and MacBook Pros, as their input devices simply don't work out of the box.

When submitting it for inclusion in the mainline kernel I guess we all agree that it's worth keeping this repository for further development. When doing so I believe it'll be way easier to maintain only a single version of the driver (let's call it mainline-next) in addition to the mainline version, instead of two (mainline-next and compatible-with-pre-4.14). As resources are scarce, they should be focused on what matters and that's from my point of view having the best possible driver in mainline and not maintaining a separate version for older kernel versions, while we don't even know if somebody needs that at all.

People installing Linux nowadays on their Macs will probably use a kernel >=4.14 anyway and people already running Linux <4.1.4 can always refer to an older version of the driver as mentioned in the README. And of course they only need to do that if they want to update the driver.

@jamesalmeida
Copy link

I wholeheartedly agree with @Dunedan

@Dunedan
Copy link
Contributor Author

Dunedan commented Jul 22, 2019

As @roadrunner2's driver was recently merged upstream this PR isn't of much use anymore.

@Dunedan Dunedan closed this Jul 22, 2019
@Dunedan Dunedan deleted the remove-support-for-old-linux-versions branch July 22, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants